Add TimeSpan alias for Duration scalar to Strawberry Shake#9401
Merged
Add TimeSpan alias for Duration scalar to Strawberry Shake#9401
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Strawberry Shake scalar code generation by treating the GraphQL TimeSpan scalar as a built-in alias of Duration, so generated C# models use System.TimeSpan instead of string (per #9392).
Changes:
- Added
TimeSpanas a default/built-in scalar mapping toSystem.TimeSpan. - Registered
TimeSpanas aDurationTypealias in schema building for codegen. - Added a new scalar generator test and snapshot for
TimeSpan.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Utilities/SchemaHelper.cs | Adds default leaf type info for TimeSpan and registers DurationType("TimeSpan") alias. |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/BuiltInScalarNames.cs | Marks TimeSpan as a built-in scalar name for schema loading/codegen decisions. |
| src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/ScalarGeneratorTests.cs | Adds a test case verifying TimeSpan scalar generation. |
| src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/snapshots/ScalarGeneratorTests.TimeSpan_Type.snap | Snapshot of the expected generated client code for TimeSpan. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ation/test/CodeGeneration.CSharp.Tests/__snapshots__/ScalarGeneratorTests.TimeSpan_Type.snap
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)
Closes #9392