Skip to content

Fix various analyzer errors#9402

Merged
glen-84 merged 1 commit intomainfrom
gai/fix-analyzer-errors
Mar 20, 2026
Merged

Fix various analyzer errors#9402
glen-84 merged 1 commit intomainfrom
gai/fix-analyzer-errors

Conversation

@glen-84
Copy link
Member

@glen-84 glen-84 commented Mar 20, 2026

Summary of the changes (Less than 80 chars)

  • Fix various analyzer errors.

Copilot AI review requested due to automatic review settings March 20, 2026 12:31
@github-actions
Copy link
Contributor

Fusion Gateway Performance Results

Progress: 0/6 benchmarks completed — this report updates as each job finishes.

Simple Composite Query

Req/s Err%
Constant 1 (50 VUs) pending pending
Ramping 1 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 1 pending pending pending pending pending pending
Ramping 1 pending pending pending pending pending pending

Deep Recursion Query

Req/s Err%
Constant 1 (50 VUs) pending pending
Ramping 1 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 1 pending pending pending pending pending pending
Ramping 1 pending pending pending pending pending pending

Variable Batching Throughput

Req/s Err%
Constant 1 (50 VUs) pending pending
Ramping 1 (0-500-0 VUs) pending pending
Response Times
Min Med Avg P90 P95 Max
Constant 1 pending pending pending pending pending pending
Ramping 1 pending pending pending pending pending pending

Runner 1 = benchmarking-1

Run 23342943080 • Commit 5e2c4ee • Fri, 20 Mar 2026 12:32:05 GMT

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses analyzer warnings/errors across multiple projects in the repository (Nitro CLI, Mocha, HotChocolate, GreenDonut) by removing unused using directives and applying small style/formatting adjustments so the codebase compiles cleanly under stricter analyzer settings.

Changes:

  • Remove unused using directives across several projects to satisfy analyzers.
  • Apply minor formatting/style fixes (brace blocks, object initializer formatting, var usage, static-field naming).
  • Minor resource reference simplification in ThrowHelper.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Nitro/CommandLine/src/CommandLine/Commands/Schemas/PublishSchemaCommand.cs Remove unused Configuration using.
src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/PublishOpenApiCollectionCommand.cs Remove unused Configuration using.
src/Nitro/CommandLine/src/CommandLine/Commands/Mcp/PublishMcpFeatureCollectionCommand.cs Remove unused Configuration using.
src/Nitro/CommandLine/src/CommandLine/Commands/Fusion/FusionPublishHelpers.cs Formatting tweak in object initializer.
src/Nitro/CommandLine/src/CommandLine/Commands/Clients/PublishClientCommand.cs Remove unused Configuration using.
src/Mocha/test/Mocha.Transport.Postgres.Tests/Behaviors/ReconnectionResilienceTests.cs Add braces around if/else blocks for analyzer/style compliance.
src/Mocha/test/Mocha.Tests/Inbox/ConsumeInboxMiddlewareTests.cs Remove unused using; rename static field to s_-prefixed name and update reference.
src/Mocha/test/Mocha.Hosting.Tests/Topology/MessageBusEndpointRouteBuilderExtensionsTests.cs Remove unused Mocha.Hosting using.
src/Mocha/test/Mocha.EntityFrameworkCore.Postgres.Tests/PostgresMessageInboxTests.cs Remove unused Mocha.EntityFrameworkCore.Postgres using.
src/Mocha/src/Mocha.EntityFrameworkCore/IDbContextOptionsConfigurationPolyfill.cs Remove unused Microsoft.EntityFrameworkCore using.
src/HotChocolate/Fusion/src/Fusion.Execution/Planning/OperationPlanner.BuildExecutionTree.cs Replace explicit nullable type with var to satisfy analyzer.
src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Clients/SourceSchemaHttpClient.cs Remove unused System.Collections.Concurrent using.
src/HotChocolate/Fusion/src/Fusion.Diagnostics/Extensions/DiagnosticsFusionGatewayBuilderExtensions.cs Remove unused System.Text/ObjectPool usings.
src/HotChocolate/Diagnostics/src/Diagnostics/Spans/ResolveFieldSpan.cs Remove unused usings (Execution, OpenTelemetry).
src/HotChocolate/Diagnostics/src/Diagnostics/Listeners/ActivityExecutionDiagnosticListener.cs Remove unused OpenTelemetry using.
src/HotChocolate/Diagnostics/src/Diagnostics/Extensions/DiagnosticsRequestExecutorBuilderExtensions.cs Remove unused System.Text/ObjectPool usings.
src/HotChocolate/Diagnostics/src/Diagnostics/ActivityEnricher.cs Formatting of empty virtual methods for analyzer/style compliance.
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/VariableCoercionSpan.cs Remove unused OpenTelemetry using.
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/ValidationSpan.cs Remove unused OpenTelemetry using.
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/ParsingSpan.cs Remove unused usings.
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/Http/ParseHttpRequestSpan.cs Remove unused OpenTelemetry using.
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/Http/FormatHttpResponseSpan.cs Remove unused OpenTelemetry using.
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/Http/ExecuteHttpRequestSpan.cs Remove unused usings (Execution, OpenTelemetry).
src/HotChocolate/Diagnostics/src/Diagnostics.Core/Spans/ExecuteOperationSpan.cs Remove unused OpenTelemetry using.
src/HotChocolate/Diagnostics/src/Diagnostics.Core/ActivityEnricherBase.cs Formatting of empty virtual methods for analyzer/style compliance.
src/HotChocolate/Core/src/Types/Utilities/ThrowHelper.cs Use statically imported resource identifier directly.
src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/ConnectionTypeFileBuilder.cs Remove unused helper using.
src/GreenDonut/test/GreenDonut.Data.Tests/Cursors/Serializers/EnumCursorKeySerializerTests.cs Remove redundant using.
src/GreenDonut/src/GreenDonut.Data/Cursors/Serializers/EnumCursorKeySerializer.cs Rename static field to s_-prefixed name and update reference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@glen-84 glen-84 merged commit afa21db into main Mar 20, 2026
128 of 134 checks passed
@glen-84 glen-84 deleted the gai/fix-analyzer-errors branch March 20, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants