Conversation
github-actions
bot
added
🌶️ hot chocolate
🌶️ strawberry shake
🌶️ green donut
🌶️ mocha
labels
Contributor
There was a problem hiding this comment.
Pull request overview
Enables stricter unused-parameter analysis and updates code across multiple projects to address unused parameters (mostly via _ discards / pragma suppressions), with a few small correctness tweaks included.
Changes:
- Configure Roslynator/IDE diagnostics to prefer RCS1163 for unused parameters and suppress it in tests.
- Replace unused parameters with
_(and add targeted#pragmasuppressions where parameter names must be preserved). - Remove a couple of unused/no-op APIs and adjust call sites; fix a few places where parameters were previously ignored.
Reviewed changes
Copilot reviewed 71 out of 71 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Mappers/StoreAccessorMapper.cs | Discard unused model parameter |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/ErrorHelper.cs | Suppress unused-parameter warning for unused lookup |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration/Analyzers/FieldCollector.cs | Discard unused directive parameter |
| src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Builders/TypeReferenceBuilder.cs | Remove unused/no-op API |
| src/StrawberryShake/Client/src/Core/CachePolicy.Defaults.cs | Discard unused subscription value |
| src/Nitro/CommandLine/src/CommandLine/Extensions/OptionExtensions.cs | Discard unused default factory argument |
| src/Nitro/CommandLine/src/CommandLine/Commands/OpenApi/ListOpenApiCollectionCommand.cs | Remove unused interactive cursor plumbing |
| src/Nitro/CommandLine/src/CommandLine.FusionCompatibility/FusionGraphPackage.cs | Rename unused cancellation token parameter |
| src/Mocha/src/Mocha/Transport/MessagingTransport.Lifecyle.cs | Discard unused finalize context |
| src/Mocha/src/Mocha/Middlewares/ReceiveContext.cs | Rename unused cancellation token parameter |
| src/Mocha/src/Mocha/MessageTypes/InboundRoute.cs | Rename unused completion context parameter |
| src/Mocha/src/Mocha.Transport.RabbitMQ/Middlewares/Receive/RabbitMQAcknowledgementMiddleware.cs | Discard unused middleware factory argument |
| src/Mocha/src/Mocha.Mediator.Abstractions/Unit.cs | Suppress unused-parameter warning for operators |
| src/HotChocolate/Spatial/src/Types/ThrowHelper.cs | Discard unused SyntaxKind parameter |
| src/HotChocolate/Spatial/src/Types/Serialization/GeoJsonGeometrySerializer.cs | Remove unused parameter from helper + update call sites |
| src/HotChocolate/Spatial/src/Data/Projections/Extensions/Extensions/QueryableSpatialProjectionScalarHandler.cs | Discard unused factory context |
| src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialGeometryDataHandler.cs | Discard unused factory context |
| src/HotChocolate/Spatial/src/Data/Filters/Expressions/Handlers/QueryableSpatialBufferDataHandler.cs | Discard unused factory context |
| src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDescendingSortOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbDefaultSortFieldHandler.cs | Discard unused factory context |
| src/HotChocolate/MongoDb/src/Data/Sorting/Handlers/MongoDbAscendingSortOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionScalarHandler.cs | Discard unused factory context |
| src/HotChocolate/MongoDb/src/Data/Projections/Convention/Handlers/MongoDbProjectionFieldHandler.cs | Discard unused factory context |
| src/HotChocolate/MongoDb/src/Data/Filters/Handlers/MongoDbDefaultFieldHandler.cs | Discard unused factory context |
| src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListSomeOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListNoneOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/MongoDb/src/Data/Filters/Handlers/List/MongoDbListAllOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/Language/src/Language.SyntaxTree/Utilities/SyntaxPrinter.cs | Suppress unused cancellation token on NETSTANDARD2_0 path |
| src/HotChocolate/Fusion/src/Fusion.Execution/Text/Json/CompositeResultElement.cs | Respect includeQuotes argument |
| src/HotChocolate/Fusion/src/Fusion.Execution/Planning/Partitioners/SelectionSetPartitioner.cs | Rename unused local function parameters |
| src/HotChocolate/Fusion/src/Fusion.Execution/Execution/Nodes/Serialization/JsonOperationPlanParser.cs | Discard unused schema parameter |
| src/HotChocolate/Fusion/benchmarks/k6/eShop.Reviews/ReviewRepository.cs | Suppress unused parameter warning |
| src/HotChocolate/Fusion/benchmarks/k6/eShop.Inventory/ProductNode.cs | Remove unused [Parent] parameter |
| src/HotChocolate/Data/test/Data.Filters.Tests/Mock/MatchAnyFieldHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDescendingSortOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableDefaultSortFieldHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Sorting/Expressions/Handlers/QueryableAscendingSortOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Optimizers/QueryableRequirementsProjectionOptimizer.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Optimizers/IsProjectedProjectionOptimizer.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Extensions/ProjectionsSchemaBuilderExtensions.cs | Discard unused DI factory argument |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableSortProjectionOptimizer.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryablePagingProjectionOptimizer.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Optimizers/QueryableFilterProjectionOptimizer.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSortInterceptor.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableSingleOrDefaultInterceptor.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFirstOrDefaultInterceptor.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Interceptor/QueryableFilterInterceptor.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionScalarHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionListHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Projections/Expressions/Handlers/QueryableProjectionFieldHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Filters/Extensions/FilterSchemaBuilderExtensions.cs | Discard unused DI factory argument |
| src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDefaultFieldHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/QueryableDataOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListSomeOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListNoneOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/Data/src/Data/Filters/Expressions/Handlers/List/QueryableListAllOperationHandler.cs | Discard unused factory context |
| src/HotChocolate/Core/src/Types/Utilities/ErrorHelper.cs | Remove unused parameters from internal helpers |
| src/HotChocolate/Core/src/Types/Types/Relay/NodeFieldResolvers.cs | Update calls to new helper signatures |
| src/HotChocolate/Core/src/Types/Types/Descriptors/TypeReferences/SyntaxTypeReference.cs | Fix WithFactory to use provided factory |
| src/HotChocolate/Core/src/Types/Text/Json/ResultElement.cs | Respect includeQuotes argument |
| src/HotChocolate/Core/src/Types/Extensions/SchemaBuilderExtensions.Middleware.cs | Discard unused factory argument |
| src/HotChocolate/Core/src/Types/Execution/ThrowHelper.cs | Improve schema mismatch error message |
| src/HotChocolate/Core/src/Types/Execution/Processing/OperationCompiler.cs | Rename unused feature-provider parameter |
| src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/TypeFileBuilderBase.cs | Remove unused parameter from helper |
| src/HotChocolate/Core/src/Types.Analyzers/FileBuilders/ObjectTypeFileBuilder.cs | Update for helper signature change |
| src/HotChocolate/Core/src/Abstractions/Execution/Tasks/ExecutionTask.cs | Remove unused/no-longer-needed API |
| src/HotChocolate/ApolloFederation/src/ApolloFederation/Types/ServerFields.cs | Discard unused resolver context |
| src/GreenDonut/src/GreenDonut.Data.EntityFramework/PagingQueryInterceptor.cs | Update call to interceptor clearing |
| src/GreenDonut/src/GreenDonut.Data.EntityFramework/Extensions/PagingQueryableExtensions.cs | Remove unused parameter from ClearQueryInterceptor |
| src/GreenDonut/src/GreenDonut.Abstractions/Promise.cs | Fix cloned argument being ignored |
| .editorconfig | Enable RCS1163 + disable IDE0060; suppress in tests |
Comments suppressed due to low confidence (1)
src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Builders/TypeReferenceBuilder.cs:33
TypeReferenceBuilderis public, and removingSetNameSpace(string @namespace)is a source/binary breaking change for any external consumers that may still call it (even if it was a no-op). If the goal is only to silence unused-parameter diagnostics, consider keeping the method (possibly[Obsolete]) and either renaming the parameter to_or suppressing the warning inside the method body instead of deleting the API.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 71 out of 71 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
src/StrawberryShake/CodeGeneration/src/CodeGeneration.CSharp/Builders/TypeReferenceBuilder.cs:34
SetNameSpacewas removed from a public builder type. Even though it was a no-op, removing it is a breaking API change for any external consumers that may still call it. Consider keeping it (e.g., as an[Obsolete]no-op that returnsthis) until a major version bump, or implement the intended namespace behavior if it should exist.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9558 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes (Less than 80 chars)