Only pull in OS specific binary when installing @chillicream/nitro#9570
Merged
tobias-tengler merged 13 commits intomainfrom Apr 17, 2026
Merged
Only pull in OS specific binary when installing @chillicream/nitro#9570tobias-tengler merged 13 commits intomainfrom
tobias-tengler merged 13 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes how the Nitro CLI is distributed on npm so that installing @chillicream/nitro only pulls the platform-specific native binary, instead of bundling all binaries in a single package.
Changes:
- Convert
@chillicream/nitroto a thin JS wrapper that resolves a platform package viaoptionalDependencies. - Add per-platform npm packages (e.g.
@chillicream/nitro-win-x64,@chillicream/nitro-linux-musl-x64) that each ship only the native binary for that platform. - Update the release workflow to publish platform packages first, then publish the main
@chillicream/nitropackage with itsoptionalDependenciespinned to the release version.
Reviewed changes
Copilot reviewed 11 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Nitro/CommandLine/src/npm/chillicream-nitro/package.json | Switches from bundled binaries to optionalDependencies on platform packages; updates repo directory metadata. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro/cli.js | New runtime resolver that finds the installed platform package and spawns the native nitro binary. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro/README.md | Adds basic README for the npm package. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro/.yarnrc.yml | Adds Yarn config for this package directory. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro/.gitignore | Adds package-local gitignore rules. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro/.gitattributes | Marks Yarn/PnP-related files as vendored/binary for linguist. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro/.editorconfig | Adds package-local editorconfig. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro-win-x86/package.json | Introduces Windows x86 binary package metadata and shipped file list. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro-win-x64/package.json | Introduces Windows x64 binary package metadata and shipped file list. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro-osx-x64/package.json | Introduces macOS x64 binary package metadata and shipped file list. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro-osx-arm64/package.json | Introduces macOS arm64 binary package metadata and shipped file list. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro-linux-x64/package.json | Introduces Linux x64 (glibc) binary package metadata and shipped file list. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro-linux-musl-x64/package.json | Introduces Linux x64 (musl) binary package metadata and shipped file list. |
| src/Nitro/CommandLine/src/npm/chillicream-nitro-linux-arm64/package.json | Introduces Linux arm64 binary package metadata and shipped file list. |
| src/Nitro/CommandLine/src/chillicream-nitro/yarn.lock | Removes the old lockfile from the previous packaging approach. |
| src/Nitro/CommandLine/src/chillicream-nitro/cli.js | Removes the old CLI resolver that relied on bundled binaries and detect-libc. |
| .github/workflows/release.yml | Updates CI release to build archives, publish per-platform npm packages, then publish the main npm package with updated optionalDependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 21 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tobias-tengler
force-pushed
the
tte/slim-npm-package
branch
from
c5a018f to
f4b267d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 21 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.