Remove HotChocolate.Types.Shared and unused build tooling#9764
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up unused build/repo artifacts by removing an empty HotChocolate package project, a vendored .NET install script that is no longer referenced, and unused .NET tool-manifest entries.
Changes:
- Removed the empty
HotChocolate.Types.Sharedproject (HotChocolate.Types.Shared.csproj) with no remaining references in the repo. - Deleted the vendored root
dotnet-install.shsince build/workflows download the script directly fromhttps://dot.net/v1/. - Removed unused tool-manifest entries (
dotnet-sonarscanner,boost.tool) from.config/dotnet-tools.json(no usages found in scripts/workflows).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/HotChocolate/Core/src/Types.Shared/HotChocolate.Types.Shared.csproj |
Removes an empty/unreferenced project to reduce solution/package surface area. |
dotnet-install.sh |
Removes a large vendored install script that is not used by repo scripts/workflows anymore. |
.config/dotnet-tools.json |
Drops unused tool entries, leaving only nuke.globaltool in the manifest. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HotChocolate.Types.Shared, which has been an empty package since Adds ResultDocument to HotChocolate Core #8931 deleted its three source files in February. No remaining references in the repo.dotnet-install.shat the repo root —build.sh/build.ps1/.devcontainer/backend/dockerfile/.github/workflows/benchmarks.ymlall download their own copy fromdot.net/v1, so the local file was dead weight.dotnet-sonarscannerandboost.toolfrom.config/dotnet-tools.json— nothing in CI or scripts invokes either.nuke.globaltoolis kept until Nuke itself is removed.Pure subtraction; no functional change to anything CI runs.
Test plan
dotnet build src/HotChocolate/Core/HotChocolate.Core.slnxpasses locally (0 warnings, 0 errors).ci.ymlPR run should pass without special-casing.