[Fusion] Prune unreachable types from source schemas after preprocessing#9767
Merged
tobias-tengler merged 3 commits intoMay 22, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9767 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Fusion composition to prune unreachable type system definitions from source schemas after preprocessing/enrichment, preventing validation/merge failures caused by orphaned types (e.g., when ExcludeByTag removes an entry-point and leaves a now-unreachable type behind).
Changes:
- Prunes unreferenced definitions from each source schema prior to source schema validation.
- Adds a regression test ensuring tag-based exclusion doesn’t accidentally trigger
InvalidFieldSharingdue to an orphaned type collision.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/HotChocolate/Fusion/src/Fusion.Composition/SchemaComposer.cs |
Adds a pruning pass over source schemas before validation to drop unreachable definitions. |
src/HotChocolate/Fusion/test/Fusion.Composition.Tests/SchemaComposerTests.cs |
Adds a test case reproducing an orphaned-type collision scenario after tag exclusion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.