Rename UNSATISFIABLE log code to UNSATISFIABLE_QUERY_PATH#9780
Merged
Conversation
github-actions
Bot
added
📚 documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aligns Fusion’s satisfiability validation diagnostic code with the Composite Schemas spec by renaming the emitted log entry code from UNSATISFIABLE to UNSATISFIABLE_QUERY_PATH, and updates the v16 docs accordingly.
Changes:
- Renamed the satisfiability log entry code constant to
UNSATISFIABLE_QUERY_PATH(LogEntryCodes.UnsatisfiableQueryPath). - Updated
SatisfiabilityValidatorto emit the new code at both error sites. - Updated Fusion v16 documentation (composition reference + migration guide) to use the new code and anchors.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/src/docs/fusion/v16/migration/migrate-from-15-to-16.md | Updates migration guide references/examples to the new satisfiability diagnostic code. |
| website/src/docs/fusion/v16/composition.md | Updates composition phase description, diagnostic reference table row, and diagnosing section heading/anchor to the new code. |
| src/HotChocolate/Fusion/src/Fusion.Composition/SatisfiabilityValidator.cs | Switches emitted log entry code for satisfiability failures to UnsatisfiableQueryPath. |
| src/HotChocolate/Fusion/src/Fusion.Composition/Logging/LogEntryCodes.cs | Renames the log code constant from Unsatisfiable to UnsatisfiableQueryPath with the new string value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UNSATISFIABLEtoUNSATISFIABLE_QUERY_PATHto match the code added by the composite schemas spec in graphql/composite-schemas-spec#218.LogEntryCodesconstant, its two call sites inSatisfiabilityValidator, and all references inwebsite/src/docs/fusion/v16/(composition reference table, diagnostics section heading and anchor, migration guide).SatisfiabilityValidatorTestsso future renames of the constant break tests directly.Test plan
dotnet build src/HotChocolate/Fusiondotnet test src/HotChocolate/Fusion/test/Fusion.Composition.Tests --filter SatisfiabilityValidator(48/48 passed across net8.0/net9.0/net10.0)