Skip to content

fix: MockAdapter.open_modal accepts positional args #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrick-chinchill merged 1 commit into from
Apr 7, 2026
Merged

fix: MockAdapter.open_modal accepts positional args #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/chat_sdk/shared/mock_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,12 @@ def is_dm(self, thread_id: str) -> bool:
def get_channel_visibility(self, thread_id: str) -> ChannelVisibility:
return "unknown"

async def open_modal(self, **kwargs: Any) -> dict[str, str]:
async def open_modal(
self,
trigger_id: str = "",
modal: Any = None,
context_id: str | None = None,
) -> dict[str, str]:
Comment on lines +170 to +175
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The trigger_id and modal parameters should be required (without default values) to match the interface defined in BaseAdapter and implemented in SlackAdapter. Using default values in the mock can lead to tests passing even when required arguments are missing in the production code, which defeats the purpose of the mock in catching interface contract violations.

Suggested change
async def open_modal(
self,
trigger_id: str = "",
modal: Any = None,
context_id: str | None = None,
) -> dict[str, str]:
async def open_modal(
self,
trigger_id: str,
modal: Any,
context_id: str | None = None,
) -> dict[str, str]:

return {"view_id": "V123"}

async def fetch_channel_messages(self, channel_id: str, options: FetchOptions | None = None) -> FetchResult:
Expand Down
Loading