process: test fidelity verification script + enforcement docs#30
Conversation
scripts/verify_test_fidelity.py enforces 1:1 test name correspondence between TS and Python. Must be run before committing test changes. CLAUDE.md and CONTRIBUTING.md updated with the required process. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates documentation regarding the test translation process and includes a critical fix for merge conflict markers in src/chat_sdk/shared/mock_adapter.py. However, the PR appears to delete core test files (test_channel.py, test_chat.py, test_thread.py) without providing the corresponding replacements, which would cause a significant loss in test coverage. The merge conflict in mock_adapter.py must be resolved immediately.
| <<<<<<< Updated upstream | ||
| trigger_id: str = "", | ||
| modal: Any = None, | ||
| ======= | ||
| trigger_id: str, | ||
| modal: Any, | ||
| >>>>>>> Stashed changes |
There was a problem hiding this comment.
Merge conflict markers detected in the code. These must be resolved before the PR can be merged. Based on the surrounding context and the adapter protocol, the version without default values for trigger_id and modal appears to be the intended implementation.
trigger_id: str,
modal: Any,| @@ -1,496 +0,0 @@ | |||
| """Tests for ChannelImpl. | |||
There was a problem hiding this comment.
This PR deletes several core test files (e.g., test_channel.py, test_chat.py, test_thread.py) but does not include their replacements (the faithful versions referenced in the MAPPING dict in scripts/verify_test_fidelity.py). This results in a significant loss of test coverage for the SDK's core logic. If the intention is to migrate to a new test structure, the new tests should be included in the same PR.
1 participant
Adds scripts/verify_test_fidelity.py. Updates CLAUDE.md and CONTRIBUTING.md with required process.