fix: merge conflict + 0.0.1a10 release#31
Merged
Conversation
529/529 TS test fidelity (100%). 3,427 tests passing. verify_test_fidelity.py enforces 1:1 name correspondence. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request resolves merge conflicts in the MockAdapter's open_modal method. A review comment suggests removing default values for trigger_id and modal to maintain consistency with the actual adapter signatures and ensure mandatory arguments are correctly tested.
Comment on lines
172
to
173
| trigger_id: str = "", | ||
| modal: Any = None, |
Contributor
There was a problem hiding this comment.
The open_modal method in MockAdapter should match the signature of the actual adapters (such as SlackAdapter) to maintain test fidelity. The real implementation requires trigger_id and modal, so the mock should not provide default values for them. Providing defaults here could hide bugs where the calling code fails to provide these mandatory arguments.
Suggested change
| trigger_id: str = "", | |
| modal: Any = None, | |
| trigger_id: str, | |
| modal: Any, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
529/529 test fidelity. 3,427 tests. Fidelity enforcement script.