Fix PocketOption websocket timeout by implementing client-side aggregation for new tick data format

[Copilot]

Problem

Users reported "Failed to execute 'GetCandles' task before the maximum allowed time of '16s'" errors when fetching candle data from PocketOption. The root cause was that PocketOption updated their websocket message format from returning aggregated OHLC candles to raw tick data.

Before (Old Format):

{
  "period": 3600,
  "data": [
    {
      "symbol_id": 291,
      "time": 1726902000,
      "open": 172.218,
      "close": 172.193,
      "high": 172.256,
      "low": 172.065
    }
  ]
}

After (New Format):

{
  "period": 0,
  "data": [
    { "asset": "EURUSD_otc", "time": 1734725463.364, "price": 1.04642 },
    { "asset": "EURUSD_otc", "time": 1734725463.864, "price": 1.04643 },
    // ... thousands more tick data points
  ]
}

Solution

Implemented smart client-side aggregation that:

1. Automatically detects the new format (period: 0 + raw tick data)
2. Aggregates tick data into proper OHLC candles for the requested time period
3. Preserves backward compatibility with existing processed candles

Key Changes

• Added candle_data_with_period() method to LoadHistoryPeriodResult
• Implemented tick data aggregation with proper OHLC calculation:
  • Open: First price in time bucket
  • Close: Last price in time bucket
  • High: Maximum price in time bucket
  • Low: Minimum price in time bucket
• Updated get_candles_advanced() to use new aggregation logic
• Added comprehensive tests for both old and new formats

Test Results

// New format: 4,154 raw ticks → 34 aggregated 60-second candles
Original data points: 4154
Aggregated candles: 34
First aggregated candle: open=1.04642, high=1.04657, low=1.04621, close=1.04651

// Old format: No changes (backward compatible)
assert_eq!(regular_candles.len(), aggregated_candles.len());

Impact

• ✅ Resolves timeout issues - Applications now receive expected candle format
• ✅ No breaking changes - Existing code continues to work unchanged
• ✅ Proper data quality - Accurate OHLC aggregation from tick data
• ✅ Future-proof - Handles both old and new PocketOption formats

Fixes #17.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

• api.ipify.org
  • Triggering command: /home/REDACTED/work/BinaryOptionsTools-v2/BinaryOptionsTools-v2/target/debug/deps/binary_options_tools-bf0e6b2adb8abbb6 (dns block)
• demo-api-eu.po.market
  • Triggering command: /home/REDACTED/work/BinaryOptionsTools-v2/BinaryOptionsTools-v2/target/debug/deps/binary_options_tools-bf0e6b2adb8abbb6 (dns block)
  • Triggering command: /home/REDACTED/work/BinaryOptionsTools-v2/BinaryOptionsTools-v2/target/debug/deps/binary_options_tools-bf0e6b2adb8abbb6 test_get_candles --nocapture (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to my firewall allow list

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[theshadow76]

We need to implement this