Add testing readiness review and action plan#2
Merged
Chris0Jeky merged 1 commit intomainfrom Nov 18, 2025
Merged
Conversation
Chris0Jeky
deleted the
codex/review-documents-and-improve-testing-strategy
branch
Chris0Jeky
added a commit
that referenced
this pull request
Feb 16, 2026
…ove-testing-strategy Add testing readiness review and action plan
This was referenced Mar 29, 2026
This was referenced Apr 8, 2026
Chris0Jeky
added a commit
that referenced
this pull request
Apr 9, 2026
TryConsumeAtomicAsync now includes ExpiresAt > now in the WHERE clause to close the TOCTOU race window between application-level expiry check and SQL execution. DeleteExpiredAsync now uses raw SQL instead of loading all rows into memory (DoS prevention). Also deletes consumed codes to prevent unbounded table growth. Uses EF Core SQLite DateTimeOffset format for correct string comparison. Addresses findings #2 (CRITICAL), #4 (HIGH), #6 (HIGH), #13 (LOW).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task