Remove unnecessary jgit pgm dependency, add annotations removed in Ja…#1
Merged
Chris2011 merged 2 commits intoChris2011:mainfrom May 4, 2022
Merged
Conversation
…va 11 Signed-off-by:Ondrej Mihályi <ondrej.mihalyi@gmail.com>
Signed-off-by:Ondrej Mihalyi <ondrej.mihalyi@payara.fish>
Owner
|
Hey @OndroMih that is just neat. Thx for this :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jgit pgm dependency brings a whole lot of other dependencies (jetty, ssh, ...), making the resulting npm package huge. It seems it's is not necessary, I don't see any reference to its packages in the source code. Removing it shrinks the npm from 16MB to less than 3MB.
To compile on Java 11+, I added
jakarta.annotation-api, which provides thejavax.annotation package, which was removed from Java 11. This is just required for compilation, not needed at runtime. It's only for thejavax.annotation.Generatedin theBundleclass.