added youtube link validations #96#104
Merged
Chris5613 merged 2 commits intoChris5613:mainfrom May 19, 2023
Merged
Conversation
Chris5613
approved these changes
May 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issue
Closes Issue #96
Handled Cases
Matching is being done with youtube code rather than the complete url. Fox example - the link
https://youtu.be/I-Gq7yhL2Cgandhttps://www.youtube.com/watch?v=I-Gq7yhL2Cg&ab_channel=EgeDenizpoints to the same video. So while submitting we need to take care of it.Matching is done with links of all the current available games. Someone could try to upload the same csgo youtube link to valorant
Please add other validations to these tasks