Merged
Conversation
Chris5613
requested changes
Jun 7, 2023
Owner
Chris5613
left a comment
Chris5613
left a comment
There was a problem hiding this comment.
If you can add a hamburger menu that would be great, I will test your code when I'm free
Owner
|
@ynzulak you're going to need to make it so it fits on a moblie screen other than that it looks pretty good |
Chris5613
requested changes
Jun 9, 2023
Owner
Chris5613
left a comment
Chris5613
left a comment
There was a problem hiding this comment.
Are you testing the code before you submit? the hamburger menu does not show.
Closed
Contributor
Author
|
I added a working burgermenu but without animations because i dont have enough time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I improved a Navbar with media queries and an animation. I only worked for 768px media queries here. I'm pulling request with a question. what do you think about making media queries by me? I can add some burger menu to it. Or even i can work for whole site. What do you think about that? Have a nice evening 😁.