Responding to Issue on video being too big on mobile published by Chris5613#75
Merged
Chris5613 merged 1 commit intoChris5613:mainfrom May 13, 2023
Merged
Conversation
adapted wrapper to be responsive to window size below 768px.
Closed
Owner
|
@hyohyo814 You might have to redo it. It looks good on small screens but if you're looking at it on a bigger screen , the video is taking up the whole page. |
Contributor
Author
|
My apologies, I might have missed some constraints when I transferred the code from VS. Thank you for pointing it out. |
Contributor
Author
Owner
|
Edit: Nevermind I was able to test it through the command line. Everything looks good! great job and thank you for making your first commit with me! Hope you stay to help more |
Chris5613
approved these changes
May 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Removed minimum size limitations in CSS and adapted wrapper to be responsive to window size below 768px.