Skip to content

Responding to Issue on video being too big on mobile published by Chris5613#75

Merged
Chris5613 merged 1 commit intoChris5613:mainfrom
hyohyo814:hyohyovidfix
May 13, 2023
Merged

Responding to Issue on video being too big on mobile published by Chris5613#75
Chris5613 merged 1 commit intoChris5613:mainfrom
hyohyo814:hyohyovidfix

Conversation

@hyohyo814
Copy link
Contributor

Removed minimum size limitations in CSS and adapted wrapper to be responsive to window size below 768px.

adapted wrapper to be responsive to window size below 768px.
@Chris5613 Chris5613 linked an issue May 13, 2023 that may be closed by this pull request
@Chris5613
Copy link
Owner

@hyohyo814 You might have to redo it. It looks good on small screens but if you're looking at it on a bigger screen , the video is taking up the whole page.

3d775082b2e0c5015c1f4132bd8071c3

@hyohyo814
Copy link
Contributor Author

My apologies, I might have missed some constraints when I transferred the code from VS. Thank you for pointing it out.

@hyohyo814
Copy link
Contributor Author

image
I am unsure of if I am running the development incorrectly, but this is what I see on a large screen running on localhost. I apologize for the inconvenience, I am still trying to familiarize myself with everything.

@Chris5613
Copy link
Owner

Chris5613 commented May 13, 2023

Edit: Nevermind I was able to test it through the command line.

Everything looks good! great job and thank you for making your first commit with me! Hope you stay to help more

@Chris5613 Chris5613 merged commit d6a8db9 into Chris5613:main May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Video too big on moblie

2 participants