Skip to content

Report video button#85

Merged
Chris5613 merged 6 commits intoChris5613:mainfrom
milan-lakhani:report-video-button-dev
May 15, 2023
Merged

Report video button#85
Chris5613 merged 6 commits intoChris5613:mainfrom
milan-lakhani:report-video-button-dev

Conversation

@milan-lakhani
Copy link
Contributor

Backend: New Schema Created - ReportForm
Backend: New route added /forms/report

Frontend: New Component created in component/Misc - ReportButton.jsx
Frontend: reportButton Added to All Game Pages.
Frontend: handled reponse from backend Success/Error in frontend

@Chris5613
Copy link
Owner

@milan-lakhani The report button looks very nice, what I would suggest is for the modal make it a pop-up instead of what you did so it doesn't push the video down or you don't really need to ask for confirmation, you can make it so the moment the user clicks it the report will send and if you're gonna do this then at the end add an alert() telling them thank you for reporting.

I also recommend deleting all the comments.

@milan-lakhani
Copy link
Contributor Author

Okay @Chris5613 Sounds good

@milan-lakhani
Copy link
Contributor Author

@Chris5613 Made the necessary changes. Should I keep the PR or create a new one?

@Chris5613
Copy link
Owner

Chris5613 commented May 15, 2023

@milan-lakhani You can keep the PR. it autmatically updates when you push.

Last thing is to change

const response = await fetch('http://localhost:3001/form/report')

to

const response = await fetch('https://rr-back-end.onrender.com/form/report')

after that I'll make the merge!

Copy link
Owner

@Chris5613 Chris5613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@Chris5613 Chris5613 linked an issue May 15, 2023 that may be closed by this pull request
@Chris5613 Chris5613 merged commit bb3a8fe into Chris5613:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report Video Button

2 participants