Merged
Conversation
Closed
Owner
|
@milan-lakhani The report button looks very nice, what I would suggest is for the modal make it a pop-up instead of what you did so it doesn't push the video down or you don't really need to ask for confirmation, you can make it so the moment the user clicks it the report will send and if you're gonna do this then at the end add an alert() telling them thank you for reporting. I also recommend deleting all the comments. |
Contributor
Author
|
Okay @Chris5613 Sounds good |
Contributor
Author
|
@Chris5613 Made the necessary changes. Should I keep the PR or create a new one? |
Owner
|
@milan-lakhani You can keep the PR. it autmatically updates when you push. Last thing is to change const response = await fetch('http://localhost:3001/form/report')to const response = await fetch('https://rr-back-end.onrender.com/form/report')after that I'll make the merge! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backend: New Schema Created - ReportForm
Backend: New route added /forms/report
Frontend: New Component created in component/Misc - ReportButton.jsx
Frontend: reportButton Added to All Game Pages.
Frontend: handled reponse from backend Success/Error in frontend