Improve responsive UI and mobile UX#21
Conversation
Reviewer's GuideThis PR refactors the main app shell layout and global styles to provide a more responsive, mobile-friendly UI while preserving all existing workflows and behavior, primarily by restructuring the navbar and main content layout into responsive flex/grid patterns, tightening overflow handling, and enhancing visual styling and focus outlines. Flow diagram for updated responsive app shell layoutflowchart LR
Body[Body<br>- overflow-x:hidden<br>- gradient background] --> AppRoot[App root div<br>- flex column<br>- overflow-x-hidden]
AppRoot --> Navbar[Navbar<br>- flex col on mobile<br>- flex row on lg<br>- responsive controls]
AppRoot --> LayoutGrid[Main layout grid<br>- 1 column on mobile<br>- sidebar/main split on xl]
LayoutGrid --> Sidebar[Sidebar<br>- max-h ~42vh on mobile<br>- border-b on mobile<br>- queue + UsageMeter]
LayoutGrid --> MainPanel[Main panel<br>- responsive padding<br>- widened content<br>- responsive cards/logs]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Using
overflow-x-hiddenon both the root app container andbodycan mask layout issues and potentially clip legitimately scrollable content; consider scoping this to specific layouts (e.g., the main shell) or ensuring there are no horizontal scroll use-cases before applying it globally. - The updated System Log JSX remains as a very long single line, which is hard to read and maintain; breaking this into multi-line JSX with clearer structure (e.g., extracting the log-row into a small helper component) would improve maintainability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Using `overflow-x-hidden` on both the root app container and `body` can mask layout issues and potentially clip legitimately scrollable content; consider scoping this to specific layouts (e.g., the main shell) or ensuring there are no horizontal scroll use-cases before applying it globally.
- The updated System Log JSX remains as a very long single line, which is hard to read and maintain; breaking this into multi-line JSX with clearer structure (e.g., extracting the log-row into a small helper component) would improve maintainability.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 57533bcc7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| )} | ||
|
|
||
| <div className="flex-1 flex overflow-hidden"> | ||
| <div className="flex-1 grid grid-cols-1 xl:grid-cols-[18rem_minmax(0,1fr)] overflow-hidden"> |
There was a problem hiding this comment.
Constrain mobile grid rows so main panel can scroll
On screens below xl, this switches the workspace to a one-column grid with implicit auto rows while the container still uses overflow-hidden. In that mode the <main> row tends to grow to content height, so overflow-y-auto on <main> does not reliably become the active scroll container and lower sections can be clipped/unreachable when analysis/report content is long. Defining explicit rows (for example auto + minmax(0,1fr)) and/or applying min-h-0 to the main grid item keeps mobile/tablet scrolling functional.
Useful? React with 👍 / 👎.
Motivation
app.tsxandsrc/styles.css, with no server, package, Docker, or API contract changes.Description
app.tsxto provide a responsive app shell: compact stacked mobile header, flexible header controls, and a grid-based workspace that becomes a sidebar/main split on larger screens to avoid horizontal overflow.src/styles.cssto refine the dark-slate premium theme, add cyan/emerald accent glow, prevent horizontal overflow (overflow-x: hidden), and add stronger:focus-visibleoutlines for accessibility.app.tsx,src/styles.cssonly.Testing
20.20.2.npm installsuccessfully.npm run buildsuccessfully.AuthScreen,/api/me,UsageMeter,PlanBadge,UpgradeModal,create-checkout-session,checkoutBanner,/api/process,/api/generate-seo, Quick Cleanse, Full Server Cleanse, manual download link/URL.revokeObjectURL, metadata analysis, and logs.Summary by Sourcery
Polish the app shell and layout for better responsive behavior across desktop and mobile while keeping existing workflows intact.
New Features:
Enhancements: