Changed scripts to bash (closes #29) AND removed duplicate code (closes #28)#32
Closed
afonsofrancof wants to merge 3 commits intoChrisTitusTech:mainfrom
Closed
Changed scripts to bash (closes #29) AND removed duplicate code (closes #28)#32afonsofrancof wants to merge 3 commits intoChrisTitusTech:mainfrom
afonsofrancof wants to merge 3 commits intoChrisTitusTech:mainfrom
Conversation
Collaborator
Author
|
I added more code on the main branch, which was automatically added to this PR. The code I added closes #28 . It makes all code depend on common-script.sh , by having the repetitive code there. |
Jak2k
approved these changes
Jul 16, 2024
Owner
|
Sadly you can't add or source other bash files from inside the linutil. We are working on a common library that gets passed to the script. I also want to stay away from using bash right now and might do some error checking while specifying sh or checking POSIX compliance before launch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #29. As stated by Meliketoaste /bin/sh is linked to the default system shell, and can be any shell, not just POSIX ones.
Check the comment bellow that explains the other changes