Skip to content

Changed scripts to bash (closes #29) AND removed duplicate code (closes #28)#32

Closed
afonsofrancof wants to merge 3 commits intoChrisTitusTech:mainfrom
afonsofrancof:main
Closed

Changed scripts to bash (closes #29) AND removed duplicate code (closes #28)#32
afonsofrancof wants to merge 3 commits intoChrisTitusTech:mainfrom
afonsofrancof:main

Conversation

@afonsofrancof
Copy link
Copy Markdown
Collaborator

@afonsofrancof afonsofrancof commented Jul 15, 2024

This PR closes #29. As stated by Meliketoaste /bin/sh is linked to the default system shell, and can be any shell, not just POSIX ones.
Check the comment bellow that explains the other changes

@afonsofrancof
Copy link
Copy Markdown
Collaborator Author

afonsofrancof commented Jul 15, 2024

I added more code on the main branch, which was automatically added to this PR.
I wanted to do it on another branch so that I could create a new PR. (Will pay more attention to this in the future)

The code I added closes #28 . It makes all code depend on common-script.sh , by having the repetitive code there.
checkEnv has been split into multiple functions which are then called by the other files when needed.

@afonsofrancof afonsofrancof changed the title Change scripts' shebang to bash Changed scripts to bash (closes #29) AND removed duplicate code (closes #28) Jul 15, 2024
@ChrisTitusTech
Copy link
Copy Markdown
Owner

Sadly you can't add or source other bash files from inside the linutil. We are working on a common library that gets passed to the script. I also want to stay away from using bash right now and might do some error checking while specifying sh or checking POSIX compliance before launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bin/sh is stupid here is why

3 participants