Fix: Use lxml parser for EEP files #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The html.parser in BeautifulSoup4 has become stricter in recent versions, and now fails to parse the EEP.xml file correctly. This commit switches the parser to `lxml`, which is more robust for XML files. The `lxml` library is also added as a dependency. This fixes issue #15.
Closed
Pull Request Test Coverage Report for Build 16859659216Details
💛 - Coveralls |
Owner
Author
|
Will use Python XML library instead of lxml, see #17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The html.parser in BeautifulSoup4 has become stricter in recent versions, and now fails to parse the EEP.xml file correctly.
This commit switches the parser to
lxml, which is more robust for XML files. Thelxmllibrary is also added as a dependency.This fixes issue #15.