Skip to content

fix(#258): remove closed PR type from ci.yml + bump version to 1.5.13#259

Merged
ChristopherRotnes merged 2 commits into
masterfrom
fix/258-remove-closed-from-ci-and-bump-version
May 15, 2026
Merged

fix(#258): remove closed PR type from ci.yml + bump version to 1.5.13#259
ChristopherRotnes merged 2 commits into
masterfrom
fix/258-remove-closed-from-ci-and-bump-version

Conversation

@ChristopherRotnes
Copy link
Copy Markdown
Owner

Summary

  • closed removed from ci.yml pull_request.types — it was sharing the same concurrency group as the push event, cancelling deploy runs on every PR merge (confirmed on PR fix(#255): add required app_location to cleanup-staging close steps #257). Staging cleanup stays in cleanup-staging.yml
  • package.json bumped from 1.5.101.5.13 — versions 1.5.11 and 1.5.12 were shipped without updating it, so Settings showed a stale version number

Test plan

  • CI passes and deploy completes without cancellation (the main thing to verify)
  • Settings page shows v1.5.13 after deploy

Closes #258

🤖 Generated with Claude Code

Removes `closed` from ci.yml pull_request.types — the closed event
shared the same concurrency group as the push event, silently
cancelling deploy runs on every PR merge. Staging cleanup stays in
cleanup-staging.yml where it belongs.

Also bumps package.json from stale 1.5.10 to 1.5.13, so the Settings
page reflects all changes shipped since 1.5.10.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fails CI if package.json version doesn't match the latest ## [x.y.z]
heading in CHANGELOG.md — prevents a repeat of the 1.5.10 stale-version
incident caught in issue #258.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ChristopherRotnes ChristopherRotnes merged commit 18d5de0 into master May 15, 2026
@ChristopherRotnes ChristopherRotnes deleted the fix/258-remove-closed-from-ci-and-bump-version branch May 15, 2026 22:47
@github-actions
Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-island-090dfd003-259.westeurope.7.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a developer I want the pull_request closed type removed from ci.yml so CI deploy runs are not silently cancelled on PR merge

1 participant