Merged
Conversation
Contributor
adamzimmermann
left a comment
adamzimmermann
left a comment
There was a problem hiding this comment.
Some questions and comments, but overall this looks like a win. I'm a touch worried about the complexity and long-term maintainability of some of this though. Those refactors could be a follow-up PR if we need this as is though.
adamzimmermann
approved these changes
Jun 13, 2023
Contributor
adamzimmermann
left a comment
adamzimmermann
left a comment
There was a problem hiding this comment.
Approving and letting you decide what else if anything you want to do.
goranmiric
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation / Context
Allow projects that use dev:refresh commands to use either DDEV or Lando.
Testing Instructions / How This Has Been Tested
Test on a project pointing to this branch.