Skip to content

Update phpcsversion to use php_current_version.#148

Merged
markdorison merged 1 commit into3.xfrom
php-version-key
Jun 29, 2023
Merged

Update phpcsversion to use php_current_version.#148
markdorison merged 1 commit into3.xfrom
php-version-key

Conversation

@markdorison
Copy link
Contributor

Description

Deprecate phpcs_php_version and rely on php_current_version for PHPCS as well.

Motivation / Context

Simplification. Lowers the chance of confusion.

@markdorison markdorison self-assigned this Jun 29, 2023
Copy link
Contributor

@adamzimmermann adamzimmermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@markdorison markdorison added the backport 2.x will automatically create backport PR to the 2.x branch when merged label Jun 29, 2023
@markdorison markdorison merged commit 7f85b79 into 3.x Jun 29, 2023
@markdorison markdorison deleted the php-version-key branch June 29, 2023 16:08
@github-actions
Copy link

Backport failed for 2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 2.x
git worktree add -d .worktree/backport-148-to-2.x origin/2.x
cd .worktree/backport-148-to-2.x
git checkout -b backport-148-to-2.x
ancref=$(git merge-base 3083c6293c63772c36f91af34a50f71cdaa5ee12 b7cda8e01dcc8479328937e8baf3a46c71f09514)
git cherry-pick -x $ancref..b7cda8e01dcc8479328937e8baf3a46c71f09514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 2.x will automatically create backport PR to the 2.x branch when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants