Conversation
Rather than modify it in the repository and potentially create weird conflicts. Generate it from an input file, instead. Use `git config --add safe.directory` to tell Git to trust the current directory, even though it is used by a different user. This is required to work around pgxn/docker-pgxn-tools#5. But also use the newly-released `pgxn/pgxn-tools:1.4` image to build the distribution, so as to use the new `GIT_BUNDLE_OPTS` variable to add the generated `META.json` file to the bundle. It would otherwise be excluded because `git archive` includes only committed files.
theory
requested review from
ChuckHend,
ianstanton,
ryw and
samay-sharma
as code owners
ChuckHend
approved these changes
Jan 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than modify it in the repository and potentially create weird conflicts. Generate it from an input file, instead.
Use
git config --add safe.directoryto tell Git to trust the current directory, even though it is used by a different user. This is required to work around pgxn/docker-pgxn-tools#5.But also use the newly-released
pgxn/pgxn-tools:1.4image to build the distribution, so as to use the newGIT_BUNDLE_OPTSvariable to add the generatedMETA.jsonfile to the bundle. It would otherwise be excluded becausegit archiveincludes only committed files.