Fix song number search to support alphanumeric values#2498
Merged
vassbo merged 1 commit intoChurchApps:devfrom Dec 4, 2025
Merged
Fix song number search to support alphanumeric values#2498vassbo merged 1 commit intoChurchApps:devfrom
vassbo merged 1 commit intoChurchApps:devfrom
Conversation
Collaborator
|
Looks good, thanks. |
vassbo
added a commit
that referenced
this pull request
Dec 9, 2025
* Fix song number search to support alphanumeric values (e.g., MP133) (#2498) * Change license from GPL-3.0 to GPL-3.0-or-later (#2500) License has to be in SPDX format and I goofed. * Fixed various freeze issues - Small tweaks * Fixed textbox selection not stored clicking a text input - Scripture fixes * Action to start audio effect - Fixed multiple of the same audio file in playlists not working - Fixed audio playlist set to not loop not clearing - Small fixes * Scripture fixes - Fixed multiple chapters not working - Fixed reference string - Slide timer fix - Stage value timing fix * Fixed history slowing app down * Fixed media folder preview * Fixed various freeze issues * Auto text break looks better * Added "Show all" checkbox to the refresh menu and a split long verses support to the scriptures collections UI. (#2517) * Added "Show all" checkbox to the refresh menu and a split long verses support to the scriptures collections UI. * Make Guide label for the Output button fit on the screen. * Quick edit scripture template background media - Scripture splits slides evenly if just two - Fixed project section dynamic value not always correct - Fixed various freeze issues * Prevent actions looping infinitely * Adding individual files over 2 GB to zip export works now - Fixes * Fixes * Fixed pasting in project name on macOS - Fixes * Broadcast local ips list - Fixes * Fixes * Update softprojector.ts (#2524) Added additional metadata when importing soft projector songs * Fixed connection * Use templates for style overrides - Template text only mode - Fixed style override not working properly for scriptures - Shortcut to convert scripture to show - Hide verse number if just one selected verse * Fixes * Fixed online media playback while downloading * Auto size fixes * Last slide only reference value - Updated Norwegian translation - Updated version --------- Co-authored-by: Yuri Vidal <yurividal@users.noreply.github.com> Co-authored-by: Erich Eickmeyer <eeickmeyer@ubuntu.com> Co-authored-by: Bohdan Ivchenko <Bogdan.Ivchenko@hotmail.com> Co-authored-by: S. O. <DrSmCraft@users.noreply.github.com>
vassbo
pushed a commit
that referenced
this pull request
Feb 13, 2026
* Fix song number search to support alphanumeric values (e.g., MP133) (#2498) * Change license from GPL-3.0 to GPL-3.0-or-later License has to be in SPDX format and I goofed. * Add libltc11 to stage-packages in snapcraft.yaml --------- Co-authored-by: Yuri Vidal <yurividal@users.noreply.github.com>
vassbo
added a commit
that referenced
this pull request
Feb 13, 2026
* Fixed chosen profile not updating projects list right away - Updated Chinese language * Fixed song upload issue #2842 * Fixed missing libltc on Linux #2841 * Fix * Set metadata display per show category - Set two different metadata templates on first & last slide - Tweaks * Updated languages * OSC /slide/{index} * Fixed context menu stacking on rapid toggle * Add missing dependency to snap (#2843) * Fix song number search to support alphanumeric values (e.g., MP133) (#2498) * Change license from GPL-3.0 to GPL-3.0-or-later License has to be in SPDX format and I goofed. * Add libltc11 to stage-packages in snapcraft.yaml --------- Co-authored-by: Yuri Vidal <yurividal@users.noreply.github.com> * App can now load without LTC dependencies #2844 * Message moved to metadata - Removed default message template - Added specific tips * Better tip matching * Quick search improvements * Template tips * Tweaks * Player videos stored in project * Drop images directly from the web * Fixed image/icon position when narrow * Fixed defaults not properly deleted * Fixed collection to show slide name issue * Profile tweaks * Updates * Fix window changing size each startup when DPI was not 100% * Version update - Package audit fix - Timeline tweak --------- Co-authored-by: Erich Eickmeyer <eeickmeyer@ubuntu.com> Co-authored-by: Yuri Vidal <yurividal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the search wasn't really working as expected, when alphanumeric song numbers:
Before this commit:
After this commit:
I don't think this breaks any current feature. at least not from my tests.