Fix the verse division when text spawns multiple chapters#2562
Merged
vassbo merged 1 commit intoChurchApps:devfrom Dec 15, 2025
Merged
Fix the verse division when text spawns multiple chapters#2562vassbo merged 1 commit intoChurchApps:devfrom
vassbo merged 1 commit intoChurchApps:devfrom
Conversation
Collaborator
|
Thank you! :) |
vassbo
added a commit
that referenced
this pull request
Dec 18, 2025
* Fixed fonts sometimes not working for special text - Fixed template freezes - Fixed thumbnail not working in ControlShow - Updated languages * Large dropdown lists should render more efficient * Context menu format tooltips - Trim now also removes double spaces * Tweaks * Tweaks * Fix scripture loading logic for collections. (#2560) * Fixed keyboard shortcuts for non-Latin keyboard layouts * Template fixes * Use original text color with stage format * Fix the verse division when text spawns multiple chapters (#2562) * Fixed event date picker not working * Deleting project folder will also delete contents * Fixed stage output removed if set to no value * Updated entitlements * Updated build files await * Fixed issues * Fixed black thumbnails for encrypted media on slide * Split text updates * Dynamic value for full show text * Fix null font-size handling in style overwrites (#2570) * Set opacity in gradient picker - Create or search shows buttons in empty project - Tweaks * Tweaks * Trying to fix merging lines removing style on macOS - Companion feedback - Tweaks * Fixed OpenLP import issue * Switch Analytics from Measurement Protocol to gtag (#2575) * Fixed next on media finished not advancing project item * JPEG EXIF moved to dynamic values - Tweaks * Fallback for dynamic values with | * Item display duration - Action activate on any output change * Download online media when added to project * Hold shift to invert group shortcut * Use templates tip * Style template in first output is used as slide preview by default - Template item mode * More RemoteShow Improvements (#2537) * Auto size fixes * Some dynamic values hidden by default - Fixed scripture issues - Fixed timer issues - Fixed line break issue - Updated Dutch language * Fixes * Updated amazing life encryption rules * Encrypting all Amazing Life content * Fixed logs * Fixed various freeze issues - Small tweaks * Fixed textbox selection not stored clicking a text input - Scripture fixes * Action to start audio effect - Fixed multiple of the same audio file in playlists not working - Fixed audio playlist set to not loop not clearing - Small fixes * Scripture fixes - Fixed multiple chapters not working - Fixed reference string - Slide timer fix - Stage value timing fix * Audio * Improvements * Revert non-remote changes to match upstream/dev * UI Updates * Fix Audio * Media * Improvements * Prettier * Revert * Alignment * Performance * Scripture * Remove Abbreviations --------- Co-authored-by: Kristoffer <kristoffervassbo@gmail.com> Co-authored-by: Jeremy Zongker <jeremy@zongker.net> * Updated dependencies - Version update --------- Co-authored-by: Bohdan Ivchenko <Bogdan.Ivchenko@hotmail.com> Co-authored-by: Yuri Vidal <yurividal@users.noreply.github.com> Co-authored-by: Jeremy Zongker <jeremy@zongker.net> Co-authored-by: Gladson Sam <115465353+gladsonsam@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2561
The previous slide generation logic would flatten the list of selected verses, losing the chapter context. This caused verses to be grouped incorrectly (example: verse 1 from each chapter would be grouped together).
The splitContent function has been updated to process verses sequentially, ensuring that all verses from one chapter are displayed before moving to the next. This maintains the correct biblical order when generating slides from multi-chapter passages.