Handle missing plan files and ship tRPC errors to Sentry#69
Merged
Conversation
Replaces overly aggressive error logging with graceful error handling that distinguishes between unexpected failures and expected conditions (like unwritten plan files). Removes the Session Inspector dev-only panel from the chat interface. Adds tRPC error reporting with redaction support and refactors plan file reading to use a Result-based API that signals file availability without throwing. These changes reduce noise in error logs while improving observability for real problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
files.readTextFileand treatnot-foundas a normal "No plan yet" empty state, andfiles.readFileno longerconsole.errors before rethrowing.errorFormatterroutes thrown errors through Sentry via a newreportTrpcErrorhelper that skips client-caused codes (BAD_REQUEST,NOT_FOUND, etc.) and sanitizes input via a sharedredactUnknownexported fromanalytics.ts.cause-preference behavior.Test plan
bun run test -- src/main/lib/trpc/index.test.ts[files] Error reading file … ENOENTline in the main-process console; sidebar shows "No plan yet" until the agent writes one.TRPCError({ code: 'NOT_FOUND' })and confirm it does not.🤖 Generated with Claude Code