UBTT_PlayAnimMontage bug fix #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver become false - remove redundant member variables
Merge Last
- refactoring UBTT_PlayAnimMontage
Merge Last
BTC_RandomSelector->RemoveUnusedChances button
- fix Montage interrupted - Code optimization
Ciberusps
reviewed
Aug 29, 2024
Comment on lines
+16
to
+26
| enum ETaskNodeEndPolicy | ||
| { | ||
| GENERATED_BODY() | ||
| /** | ||
| * after the node ends, still need to perform montage node, using this policy can make the anime more coherent | ||
| */ | ||
| OnMontageBlendingOut, | ||
|
|
||
| public: | ||
|
|
||
| /** | ||
| * try to Play montage and create callback. | ||
| * If played successfully, return callback. otherwise return null | ||
| * end when the montage is completely finished, applicable to situations where only one montage is executed | ||
| */ | ||
| static UMyPlayMontageCallbackProxy* TryCreateProxyObjectForPlayMontage( | ||
| USkeletalMeshComponent* InSkeletalMeshComponent, | ||
| UAnimMontage* MontageToPlay, | ||
| float PlayRate = 1.f, | ||
| float StartingPosition = 0.f, | ||
| FName StartingSection = NAME_None) | ||
| { | ||
| UMyPlayMontageCallbackProxy* Proxy = NewObject<UMyPlayMontageCallbackProxy>(); | ||
|
|
||
| if(Proxy->PlayMontage(InSkeletalMeshComponent, MontageToPlay, PlayRate, StartingPosition, StartingSection)) | ||
| { | ||
| Proxy->SetFlags(RF_StrongRefOnFrame); | ||
| return Proxy; | ||
| } | ||
|
|
||
| Proxy->MarkAsGarbage(); | ||
| return nullptr; | ||
| } | ||
| OnMontageEnded |
Owner
|
Sry cant check for now, will check on saturday (10% chance - tomorrow 🙃) |
Owner
|
Testing on UPD |
Ciberusps
previously approved these changes
Sep 1, 2024
Ciberusps
reviewed
Sep 1, 2024
Ciberusps
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the best version currently available