Redesign auth commands for multi-provider support#212
Closed
schurchleycci wants to merge 3 commits intoconfig-circleci-tokenfrom
Closed
Redesign auth commands for multi-provider support#212schurchleycci wants to merge 3 commits intoconfig-circleci-tokenfrom
schurchleycci wants to merge 3 commits intoconfig-circleci-tokenfrom
Conversation
Contributor
|
Is it being branched off of circleci-client-extract instead of main on purpose |
Contributor
Author
Yeah, the three PRs are stacked - so when the first PR merges, the second one will automatically change to main as the base, and same thing when that one merges. |
schurchleycci
force-pushed
the
auth-redesign
branch
from
7e90e61 to
9bd2a41
Compare
schurchleycci
force-pushed
the
circleci-client-extract
branch
2 times, most recently
from
6d78f14 to
dfc4218
Compare
schurchleycci
force-pushed
the
auth-redesign
branch
from
9bd2a41 to
1f8e654
Compare
schurchleycci
changed the base branch from
circleci-client-extract
to
config-circleci-token
3 tasks
schurchleycci
force-pushed
the
auth-redesign
branch
from
1f8e654 to
c2b3c69
Compare
Support storing and resolving CircleCI tokens through the config system, with the same env-var > config-file precedence as API keys. Add `auth set-circleci` command that prompts for a token, validates it against the CircleCI API, and saves it to config. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename login/logout to set/remove with provider dispatch (circleci, anthropic). Auth status now shows three sections: CircleCI, Anthropic, and GitHub. Add ErrSilent for cleaner error output. Update init flow to prompt for CircleCI token with validation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
schurchleycci
force-pushed
the
config-circleci-token
branch
from
3234ded to
b9aba32
Compare
schurchleycci
force-pushed
the
auth-redesign
branch
from
c2b3c69 to
22cccac
Compare
The circleCIToken field should only be set via `auth set circleci` which validates the token. Remove incorrect docs claiming config set accepts it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| return nil | ||
| } | ||
|
|
||
| if err := config.ClearAPIKey(); err != nil { |
Contributor
There was a problem hiding this comment.
if we're being provider specific i'd at least rename this to ClearAnthropicAPIKey. Even better just have an Clear() function that handles the provider as an enum or accepts a known config key name.
schurchleycci
force-pushed
the
config-circleci-token
branch
5 times, most recently
from
6cfa14a to
034cc8a
Compare
This was referenced Apr 13, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth login/logouttoauth set/removewith provider dispatch (circleci,anthropic)auth set-circlecifrom Add CircleCI token as first-class config option #210 becomesauth set circleci(default provider)auth statusnow shows three sections: CircleCI, Anthropic, and GitHubnewCircleCIClient()helper and update all command callers (task,sandbox,validate) to resolve tokens from configinitflow to prompt for CircleCI token with validationTest plan
task buildcompiles cleanlytask testpasses (735 tests, including updated acceptance tests)chunk auth set circleciprompts and validates tokenchunk auth set anthropicworks as before (renamed fromlogin)chunk auth statusshows all three provider sectionschunk auth remove circleciclears stored token🤖 Generated with Claude Code
Note
Part 2 of 2 — stacked on #210. Merge that first.