391 span filter group #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 90.36% 90.43% +0.07%
==========================================
Files 165 168 +3
Lines 7348 7415 +67
Branches 1073 1079 +6
==========================================
+ Hits 6640 6706 +66
Misses 599 599
- Partials 109 110 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sajagana
requested changes
Apr 6, 2023
tests/integration/targets/aci_access_span_filter_group_entry/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/aci_access_span_filter_group_entry/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/aci_access_span_filter_group_entry/tasks/main.yml
Outdated
Show resolved
Hide resolved
Comment on lines
301
to
304
| CHOICE_MAPPING.get(first_src_port, first_src_port) if first_src_port else "unspecified", | ||
| CHOICE_MAPPING.get(last_src_port, last_src_port) if last_src_port else "unspecified", | ||
| CHOICE_MAPPING.get(first_dest_port, first_dest_port) if first_dest_port else "unspecified", | ||
| CHOICE_MAPPING.get(last_dest_port, last_dest_port) if last_dest_port else "unspecified", |
Collaborator
There was a problem hiding this comment.
Can we use a simple function to return the port value?
def get_port_value(port):
return CHOICE_MAPPING.get(port, port) if port else "unspecified"
anvitha-jain
requested changes
Apr 6, 2023
lhercot
requested changes
Apr 7, 2023
…n filter group support
…ss span filter group support
…ilter_port_mapping
akinross
force-pushed
the
391_span_filter_group
branch
from
18654ca to
19c5812
Compare
shrsr
requested changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.