-
Notifications
You must be signed in to change notification settings - Fork 107
391 span filter group #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b7de5cc
[minor_change] add aci_access_span_filter_group module for access spa…
akinross 2af8a39
[minor_change] add aci_access_span_filter_group_entry module for acce…
akinross 2854937
[ignore] add function for getting port value from mapping
akinross ce34498
[ignore] adjust task descriptions and clean up filter groups at test …
akinross 3c0e307
[ignore] allow port inputs as digits
akinross 19c5812
[ignore] leverage mapping from constants.py for valid_ip_protocols, f…
akinross 9bbd54f
[ignore] add empty lines between functions for consistency with other…
akinross File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| VALID_IP_PROTOCOLS = ["eigrp", "egp", "icmp", "icmpv6", "igmp", "igp", "l2tp", "ospfigp", "pim", "tcp", "udp", "unspecified"] | ||
|
|
||
| FILTER_PORT_MAPPING = {"443": "https", "25": "smtp", "80": "http", "53": "dns", "22": "ssh", "110": "pop3", "554": "rtsp", "20": "ftpData", "ftp": "ftpData"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,248 @@ | ||
| #!/usr/bin/python | ||
| # -*- coding: utf-8 -*- | ||
|
|
||
| # Copyright: (c) 2023, Akini Ross <akinross@cisco.com> | ||
| # GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt) | ||
|
|
||
| from __future__ import absolute_import, division, print_function | ||
|
|
||
| __metaclass__ = type | ||
|
|
||
| ANSIBLE_METADATA = {"metadata_version": "1.1", "status": ["preview"], "supported_by": "certified"} | ||
|
|
||
| DOCUMENTATION = r""" | ||
| --- | ||
| module: aci_access_span_filter_group | ||
| short_description: Manage Access SPAN filter groups (span:FilterGrp) | ||
| description: | ||
| - Manage Access SPAN filter groups on Cisco ACI fabrics. | ||
| options: | ||
| filter_group: | ||
| description: | ||
| - The name of the Access SPAN filter group. | ||
| type: str | ||
| aliases: [ name ] | ||
| state: | ||
| description: | ||
| - Use C(present) or C(absent) for adding or removing. | ||
| - Use C(query) for listing an object or multiple objects. | ||
| type: str | ||
| choices: [ absent, present, query ] | ||
| default: present | ||
| name_alias: | ||
| description: | ||
| - The alias for the current object. This relates to the nameAlias field in ACI. | ||
| type: str | ||
| extends_documentation_fragment: | ||
| - cisco.aci.aci | ||
| - cisco.aci.annotation | ||
|
|
||
| seealso: | ||
| - name: APIC Management Information Model reference | ||
| description: More information about the internal APIC class B(span:DestGrp). | ||
| link: https://developer.cisco.com/docs/apic-mim-ref/ | ||
| author: | ||
| - Akini Ross (@akinross) | ||
| """ | ||
|
|
||
| EXAMPLES = r""" | ||
| - name: Add a Access SPAN filter group | ||
| cisco.aci.aci_access_span_filter_group: | ||
| host: apic | ||
| username: admin | ||
| password: SomeSecretPassword | ||
| filter_group: group1 | ||
| state: present | ||
| delegate_to: localhost | ||
|
|
||
| - name: Remove a Access SPAN filter group | ||
| cisco.aci.aci_access_span_filter_group: | ||
| host: apic | ||
| username: admin | ||
| password: SomeSecretPassword | ||
| filter_group: group1 | ||
| state: absent | ||
| delegate_to: localhost | ||
|
|
||
| - name: Query a Access SPAN filter group | ||
| cisco.aci.aci_access_span_filter_group: | ||
| host: apic | ||
| username: admin | ||
| password: SomeSecretPassword | ||
| filter_group: group1 | ||
| state: query | ||
| delegate_to: localhost | ||
|
|
||
| - name: Query all Access SPAN filter groups | ||
| cisco.aci.aci_access_span_filter_group: | ||
| host: apic | ||
| username: admin | ||
| password: SomeSecretPassword | ||
| state: query | ||
| delegate_to: localhost | ||
| """ | ||
|
|
||
| RETURN = r""" | ||
| current: | ||
| description: The existing configuration from the APIC after the module has finished | ||
| returned: success | ||
| type: list | ||
| sample: | ||
| [ | ||
| { | ||
| "fvTenant": { | ||
| "attributes": { | ||
| "descr": "Production environment", | ||
| "dn": "uni/tn-production", | ||
| "name": "production", | ||
| "nameAlias": "", | ||
| "ownerKey": "", | ||
| "ownerTag": "" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| error: | ||
| description: The error information as returned from the APIC | ||
| returned: failure | ||
| type: dict | ||
| sample: | ||
| { | ||
| "code": "122", | ||
| "text": "unknown managed object class foo" | ||
| } | ||
| raw: | ||
| description: The raw output returned by the APIC REST API (xml or json) | ||
| returned: parse error | ||
| type: str | ||
| sample: '<?xml version="1.0" encoding="UTF-8"?><imdata totalCount="1"><error code="122" text="unknown managed object class foo"/></imdata>' | ||
| sent: | ||
| description: The actual/minimal configuration pushed to the APIC | ||
| returned: info | ||
| type: list | ||
| sample: | ||
| { | ||
| "fvTenant": { | ||
| "attributes": { | ||
| "descr": "Production environment" | ||
| } | ||
| } | ||
| } | ||
| previous: | ||
| description: The original configuration from the APIC before the module has started | ||
| returned: info | ||
| type: list | ||
| sample: | ||
| [ | ||
| { | ||
| "fvTenant": { | ||
| "attributes": { | ||
| "descr": "Production", | ||
| "dn": "uni/tn-production", | ||
| "name": "production", | ||
| "nameAlias": "", | ||
| "ownerKey": "", | ||
| "ownerTag": "" | ||
| } | ||
| } | ||
| } | ||
| ] | ||
| proposed: | ||
| description: The assembled configuration from the user-provided parameters | ||
| returned: info | ||
| type: dict | ||
| sample: | ||
| { | ||
| "fvTenant": { | ||
| "attributes": { | ||
| "descr": "Production environment", | ||
| "name": "production" | ||
| } | ||
| } | ||
| } | ||
| filter_string: | ||
| description: The filter string used for the request | ||
| returned: failure or debug | ||
| type: str | ||
| sample: ?rsp-prop-include=config-only | ||
| method: | ||
| description: The HTTP method used for the request to the APIC | ||
| returned: failure or debug | ||
| type: str | ||
| sample: POST | ||
| response: | ||
| description: The HTTP response from the APIC | ||
| returned: failure or debug | ||
| type: str | ||
| sample: OK (30 bytes) | ||
| status: | ||
| description: The HTTP status from the APIC | ||
| returned: failure or debug | ||
| type: int | ||
| sample: 200 | ||
| url: | ||
| description: The HTTP url used for the request to the APIC | ||
| returned: failure or debug | ||
| type: str | ||
| sample: https://10.11.12.13/api/mo/uni/tn-production.json | ||
| """ | ||
|
|
||
| from ansible.module_utils.basic import AnsibleModule | ||
| from ansible_collections.cisco.aci.plugins.module_utils.aci import ACIModule, aci_argument_spec, aci_annotation_spec | ||
|
|
||
|
|
||
| def main(): | ||
| argument_spec = aci_argument_spec() | ||
| argument_spec.update(aci_annotation_spec()) | ||
| argument_spec.update( | ||
| filter_group=dict(type="str", aliases=["name"]), # Not required for querying all objects | ||
| name_alias=dict(type="str"), | ||
| state=dict(type="str", default="present", choices=["absent", "present", "query"]), | ||
| ) | ||
|
|
||
| module = AnsibleModule( | ||
| argument_spec=argument_spec, | ||
| supports_check_mode=True, | ||
| required_if=[ | ||
| ["state", "absent", ["filter_group"]], | ||
| ["state", "present", ["filter_group"]], | ||
| ], | ||
| ) | ||
|
|
||
| aci = ACIModule(module) | ||
|
|
||
| filter_group = module.params.get("filter_group") | ||
| state = module.params.get("state") | ||
| name_alias = module.params.get("name_alias") | ||
|
|
||
| aci.construct_url( | ||
| root_class=dict( | ||
| aci_class="infra", | ||
| aci_rn="infra", | ||
| ), | ||
| subclass_1=dict( | ||
| aci_class="spanFilterGrp", | ||
| aci_rn="filtergrp-{0}".format(filter_group), | ||
| module_object=filter_group, | ||
| target_filter={"name": filter_group}, | ||
| ), | ||
| child_classes=["spanFilterEntry"], | ||
| ) | ||
|
|
||
| aci.get_existing() | ||
|
|
||
| if state == "present": | ||
| aci.payload(aci_class="spanFilterGrp", class_config=dict(name=filter_group, nameAlias=name_alias)) | ||
|
|
||
| aci.get_diff(aci_class="spanFilterGrp") | ||
akinross marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| aci.post_config() | ||
|
|
||
| elif state == "absent": | ||
| aci.delete_config() | ||
|
|
||
| aci.exit_json() | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.