Skip to content

[minor_change] Add missing test cases for existing modules. #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Aug 29, 2023
Merged

[minor_change] Add missing test cases for existing modules. #453

merged 31 commits into from
Aug 29, 2023

Conversation

@gmicol
Copy link
Collaborator

@gmicol gmicol commented Jun 30, 2023

Solve #435

@gmicol
Copy link
Collaborator Author

gmicol commented Jun 30, 2023

Missing test case for aci_bd_to_l3out added.

@gmicol gmicol linked an issue Jun 30, 2023 that may be closed by this pull request
Missing test cases for existing modules #435
Closed
@codecov
Copy link

codecov bot commented Jun 30, 2023 •
edited
Loading

Codecov Report

Patch coverage: 36.48% and project coverage change: -57.20% ⚠️

Comparison is base (86243d2) 92.78% compared to head (02d34a0) 35.59%.

❗ Current head 02d34a0 differs from pull request most recent head ad05c91. Consider uploading reports for the commit ad05c91 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #453       +/-   ##
===========================================
- Coverage   92.78%   35.59%   -57.20%     
===========================================
  Files         181      181               
  Lines        8237     8291       +54     
  Branches     1220     1222        +2     
===========================================
- Hits         7643     2951     -4692     
- Misses        525     5340     +4815     
+ Partials       69        0       -69
Flag Coverage Δ
integration ?
sanity 35.59% <36.48%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/modules/aci_interface_policy_lldp.py 50.00% <ø> (ø)
plugins/modules/aci_interface_policy_ospf.py 30.76% <ø> (-69.24%) ⬇️
...ugins/modules/aci_interface_policy_port_channel.py 31.37% <ø> (ø)
plugins/modules/aci_maintenance_group_node.py 46.87% <0.00%> (-4.85%) ⬇️
plugins/modules/aci_tenant_ep_retention_policy.py 29.31% <0.00%> (ø)
plugins/modules/aci_interface_policy_mcp.py 44.73% <14.28%> (-6.88%) ⬇️
plugins/modules/aci_interface_policy_fc.py 45.94% <16.66%> (-5.67%) ⬇️
plugins/modules/aci_maintenance_policy.py 38.29% <16.66%> (-7.16%) ⬇️
plugins/modules/aci_firmware_policy.py 45.94% <30.00%> (-2.54%) ⬇️
plugins/modules/aci_firmware_group_node.py 46.87% <40.00%> (-4.85%) ⬇️
... and 4 more

... and 159 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmicol
Copy link
Collaborator Author

gmicol commented Jun 30, 2023

Missing test case for aci_l3out_route_tag_policy added.

sajagana
sajagana previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrsr
shrsr previously approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrsr
Copy link
Collaborator

shrsr commented Jul 5, 2023

I'm not sure why but there is an indentation error in the aci_contract module related to sanity check

anvitha-jain
anvitha-jain requested changes Jul 13, 2023
View reviewed changes
@gmicol gmicol dismissed stale reviews from shrsr and sajagana via 8c1edde July 18, 2023 02:48
@gmicol gmicol force-pushed the 435-missing_test_cases branch from c77b90a to 8c1edde Compare July 18, 2023 02:48
@gmicol
Copy link
Collaborator Author

gmicol commented Jul 18, 2023

Missing test case added for:

  • aci_maintenance_policy
  • aci_maintenance_group
  • aci_maintenance_group_node
  • aci_fabric_scheduler
  • aci_firmware_policy
  • aci_firmware_group
  • aci_firmware_group_node

@gmicol
Copy link
Collaborator Author

gmicol commented Jul 18, 2023

Missing test cases added:

  • aci_interface_policy_fc
  • aci_interface_policy_l2

@gmicol
Copy link
Collaborator Author

gmicol commented Jul 18, 2023

Missing test cases added:

  • aci_interface_policy_lldp
  • aci_interface_policy_mcp
  • aci_interface_policy_port_channel

@gmicol
Copy link
Collaborator Author

gmicol commented Jul 19, 2023

Last missing test cases added:

  • aci_tenant_action_rule
  • aci_tenant_ep_retention_policy

akinross
akinross requested changes Jul 24, 2023
View reviewed changes
anvitha-jain
anvitha-jain requested changes Jul 25, 2023
View reviewed changes
@gmicol gmicol force-pushed the 435-missing_test_cases branch from 83eee88 to 04a7ad1 Compare July 27, 2023 17:19
@gmicol gmicol requested review from akinross and anvitha-jain July 27, 2023 17:23
anvitha-jain
anvitha-jain requested changes Jul 28, 2023
View reviewed changes
@gmicol gmicol requested a review from anvitha-jain July 28, 2023 17:48
shrsr
shrsr requested changes Jul 28, 2023
View reviewed changes
@gmicol gmicol requested a review from shrsr August 1, 2023 18:04
gmicol added 17 commits August 22, 2023 07:40
@gmicol
[ignore] Rebase 1.
bc329b1
@gmicol
[ignore] Rebase 2.
bb28a87
@gmicol
[ignore] Modify python files for asserting sanity and formating checks.
9ead5a7
@gmicol
[ignore] Modify documentation for aci_interface_policy_fc.
183c17f
@gmicol
[ignore] Modify names of tasks for test files.
6739017
@gmicol
[ignore] Modify Documentations and module for aci_interface_policy_mcp.
8b5cc17
@gmicol
[ignore] Modify Documentations for certain modules.
e218500
@gmicol
[ignore] Modify formating for aci_interface_policy_mcp.
7f5f48c
@gmicol
Revert "[ignore] Modify formating for aci_interface_policy_mcp."
4a99c2b 
This reverts commit 5619bc4.
@gmicol
[ignore] Modify aci firmware group node, firmware policy and maintena…
ce449ef 
…nce policy python scripts.
@gmicol
[ignore] Apply black and format the previous modified files.
d642df8
@gmicol
[ignore] Modify type attribute for aci maintenance group and firmware…
160e112 
… group.
@gmicol
[ignore] Modify aci_interface_policy_fc, aci_firmware_policy and aci_…
1a6cd2d 
…maintenance_policy to add constants.
@gmicol
[ignore] Apply Black for formating - after adding constants.
77ed551
@gmicol
[ignore] Add aliases for attribute input ignore_compat in maintenance…
8e1734d 
… and firmware policy.
@gmicol
[ignore] modify run_mode attributes for aci_maintenance_policy.py
319641c
@gmicol
[ignore] Modify run_mode choices to check sanity test in aci_maintena…
ad05c91 
…nce_policy.
@gmicol gmicol dismissed stale reviews from anvitha-jain and shrsr via ad05c91 August 22, 2023 11:40
@gmicol gmicol force-pushed the 435-missing_test_cases branch from 207c3de to ad05c91 Compare August 22, 2023 11:40
@gmicol
Copy link
Collaborator Author

gmicol commented Aug 22, 2023

I see sanity failing also, did you check this?

I made a few changes to the pr so that the sanity tests are successful

akinross
akinross approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Aug 28, 2023
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 658ea51 into CiscoDevNet:master Aug 29, 2023
@lhercot lhercot mentioned this pull request Jul 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhercot lhercot lhercot approved these changes

@shrsr shrsr shrsr approved these changes

@akinross akinross akinross approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

@abrahammughal abrahammughal Awaiting requested review from abrahammughal

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing test cases for existing modules

6 participants

@gmicol @shrsr @akinross @lhercot @anvitha-jain @sajagana