[minor_change] Add missing test cases for existing modules.

plugins/module_utils/constants.py

@@ -46,3 +46,45 @@
     redhat="Redhat",
     vmware="VMware",
 )
+
+MATCH_TYPE_GROUP_MAPPING = {"all": "ALL", "all_in_pod": "ALL_IN_POD", "range": "range"}
+
+MATCH_FC_FILL_PATTERN_MAPPING = {"arbff": "ARBFF", "idle": "IDLE"}
+
+MATCH_FIRMWARE_NODES_TYPE_MAPPING = {
+    "c_apic_patch": "cApicPatch",
+    "catalog": "catalog",
+    "config": "config",
+    "controller": "controller",
+    "controller_patch": "controllerPatch",
+    "plugin": "plugin",
+    "plugin_package": "pluginPackage",
+    "switch": "switch",
+    "switch_patch": "switchPatch",
+    "vpod": "vpod",
+}
+
+MATCH_TRIGGER_MAPPING = {
+    "trigger": "trigger",
+    "trigger_immediate": "trigger-immediate",
+    "triggered": "triggered",
+    "untriggered": "untriggered",
+}
+
+INTERFACE_POLICY_FC_SPEED_LIST = ["auto", "unknown", "2G", "4G", "8G", "16G", "32G"]
+
+MATCH_RUN_MODE_MAPPING = dict(
+    pause_always_between_sets="pauseAlwaysBetweenSets",
+    pause_only_on_failures="pauseOnlyOnFailures",
+    pause_never="pauseNever",
+)
+
+MATCH_NOTIFY_CONDITION_MAPPING = dict(
+    notify_always_between_sets="notifyAlwaysBetweenSets",
+    notify_never="notifyNever",
+    notify_only_on_failures="notifyOnlyOnFailures",
+)
+
+MATCH_SMU_OPERATION_MAPPING = dict(smu_install="smuInstall", smu_uninstall="smuUninstall")
+
+MATCH_SMU_OPERATION_FLAGS_MAPPING = dict(smu_reload_immediate="smuReloadImmediate", smu_reload_skip="smuReloadSkip")

plugins/modules/aci_fabric_scheduler.py

@@ -9,16 +9,12 @@
 
 ANSIBLE_METADATA = {"metadata_version": "1.1", "status": ["preview"], "supported_by": "community"}
 
-DOCUMENTATION = """
+DOCUMENTATION = r"""
 ---
 module: aci_fabric_scheduler
-
-short_description: This modules creates ACI schedulers.
-
-
+short_description: This module creates ACI schedulers (trig:SchedP)
 description:
-    -   With the module you can create schedule policies that can be a shell, onetime execution or recurring
-
+- With the module you can create schedule policies that can be a shell, one-time execution or recurring.
 options:
   name:
     description:
@@ -32,44 +28,44 @@
     aliases: [ descr ]
   recurring:
     description:
-    - If you want to make the Scheduler a recurring it would be a "True" and for a
-      oneTime execution it would be "False". For a shell just exclude this option from
-      the task
+    - If you want to make the scheduler a recurring operation, it should be set C(True) and for a one-time execution it should be C(False).
+    - For a shell, just exclude this option from the task.
     type: bool
   windowname:
     description:
-       - This is the name for your what recurring or oneTime execution
+    - The name of the schedule window.
+    - This is mandatory for the child class object B(trig:AbsWinddowP)
     type: str
   concurCap:
     description:
-       - This is the amount of devices that can be executed on at a time
+    - The amount of devices that can be executed on at a time.
     type: int
   maxTime:
     description:
-       - This is the amount MAX amount of time a process can be executed
+    - The maximum amount of time a process can be executed.
     type: str
   date:
     description:
-       - This is the date and time that the scheduler will execute
+    - The date and time that the scheduler will execute.
     type: str
   hour:
     description:
-       - This set the hour of execution
+    - The number of hours of execution.
     type: int
   minute:
     description:
-       - This sets the minute of execution, used in conjunction with hour
+    - The number of minutes of execution, used in conjunction with hour.
     type: int
   day:
     description:
-       - This sets the day when execution will take place
+    - The number of days when execution will take place.
     type: str
-    default: "every-day"
-    choices: ['Monday', 'Tuesday', 'Wednesday', 'Thursday', 'Friday', 'Saturday','Sunday', 'even-day', 'odd-day', 'every-day']
+    default: every-day
+    choices: [ Monday, Tuesday, Wednesday, Thursday, Friday, Saturday, Sunday, even-day, odd-day, every-day ]
   state:
     description:
-       - Use C(present) or C(absent) for adding or removing.
-       - Use C(query) for listing an object or multiple objects.
+    - Use C(present) or C(absent) for adding or removing.
+    - Use C(query) for listing an object or multiple objects.
     type: str
     default: present
     choices: [ absent, present, query ]
@@ -82,56 +78,63 @@
 - cisco.aci.annotation
 - cisco.aci.owner
 
+seealso:
+- name: APIC Management Information Model reference
+  description: More information about the internal APIC class B(trig:SchedP).
+  link: https://developer.cisco.com/docs/apic-mim-ref/
 author:
-    - Steven Gerhart (@sgerhart)
+- Steven Gerhart (@sgerhart)
 """
 
 EXAMPLES = r"""
-   - name: Simple Scheduler (Empty)
-     cisco.aci.aci_fabric_scheduler:
-        host: "{{ inventory_hostname }}"
-        username: "{{ user }}"
-        password: "{{ pass }}"
-        validate_certs: false
-        name: simpleScheduler
-        state: present
-   - name: Remove Simple Scheduler
-     cisco.aci.aci_fabric_scheduler:
-        host: "{{ inventory_hostname }}"
-        username: "{{ user }}"
-        password: "{{ pass }}"
-        validate_certs: false
-        name: simpleScheduler
-        state: absent
-   - name: One Time Scheduler
-     cisco.aci.aci_fabric_scheduler:
-        host: "{{ inventory_hostname }}"
-        username: "{{ user }}"
-        password: "{{ pass }}"
-        validate_certs: false
-        name: OneTime
-        windowname: OneTime
-        recurring: False
-        concurCap: 20
-        date: "2018-11-20T24:00:00"
-        state: present
-   - name: Recurring Scheduler
-     cisco.aci.aci_fabric_scheduler:
-        host: "{{ inventory_hostname }}"
-        username: "{{ user }}"
-        password: "{{ pass }}"
-        validate_certs: false
-        name: Recurring
-        windowname: Recurring
-        recurring: True
-        concurCap: 20
-        hour: 13
-        minute: 30
-        day: Tuesday
-        state: present
+- name: Simple Scheduler (Empty)
+  cisco.aci.aci_fabric_scheduler:
+    host: "{{ inventory_hostname }}"
+    username: "{{ user }}"
+    password: "{{ pass }}"
+    validate_certs: false
+    name: simpleScheduler
+    state: present
+
+- name: Remove Simple Scheduler
+  cisco.aci.aci_fabric_scheduler:
+    host: "{{ inventory_hostname }}"
+    username: "{{ user }}"
+    password: "{{ pass }}"
+    validate_certs: false
+    name: simpleScheduler
+    state: absent
+
+- name: One Time Scheduler
+  cisco.aci.aci_fabric_scheduler:
+    host: "{{ inventory_hostname }}"
+    username: "{{ user }}"
+    password: "{{ pass }}"
+    validate_certs: false
+    name: OneTime
+    windowname: OneTime
+    recurring: False
+    concurCap: 20
+    date: "2018-11-20T24:00:00"
+    state: present
+
+- name: Recurring Scheduler
+  cisco.aci.aci_fabric_scheduler:
+    host: "{{ inventory_hostname }}"
+    username: "{{ user }}"
+    password: "{{ pass }}"
+    validate_certs: false
+    name: Recurring
+    windowname: Recurring
+    recurring: True
+    concurCap: 20
+    hour: 13
+    minute: 30
+    day: Tuesday
+    state: present
 """
 
-RETURN = """
+RETURN = r"""
 current:
   description: The existing configuration from the APIC after the module has finished
   returned: success
@@ -285,6 +288,11 @@ def main():
     description = module.params.get("description")
     name_alias = module.params.get("name_alias")
 
+    child_classes = [
+        "trigRecurrWindowP",
+        "trigAbsWindowP",
+    ]
+
     if recurring:
         child_configs = [
             dict(
@@ -324,6 +332,7 @@ def main():
             target_filter={"name": name},
             module_object=name,
         ),
+        child_classes=child_classes,
     )
 
     aci.get_existing()