Add Netflow Policies as new modules. #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #582 +/- ##
==========================================
+ Coverage 96.30% 96.32% +0.01%
==========================================
Files 241 245 +4
Lines 11024 11196 +172
Branches 1658 1690 +32
==========================================
+ Hits 10617 10784 +167
- Misses 308 309 +1
- Partials 99 103 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gmicol
requested review from
akinross,
anvitha-jain,
lhercot,
sajagana,
samiib and
shrsr
akinross
requested changes
Jan 15, 2024
akinross
reviewed
Jan 15, 2024
gmicol
force-pushed
the
aci_netflow_monitor_pol
branch
from
60d3662 to
1a43d02
Compare
akinross
requested changes
Jan 22, 2024
gmicol
force-pushed
the
aci_netflow_monitor_pol
branch
from
41d9b0c to
e343ff6
Compare
…policy as new modules.
…d add integration test for aci_netflow_exporter_policy.
…w_exporter_policy.
…y and Add more assertions for all test files.
… and modify all test files.
gmicol
force-pushed
the
aci_netflow_monitor_pol
branch
from
cd96418 to
5a80ac1
Compare
samiib
requested changes
Jan 28, 2024
anvitha-jain
previously approved these changes
Jan 29, 2024
sajagana
requested changes
Jan 31, 2024
| delegate_to: localhost | ||
|
|
||
| - name: Delete a Netflow Monitor Policy | ||
| cisco.aci.aci_netflow_monitor_policy: |
Collaborator
There was a problem hiding this comment.
Suggested change
| cisco.aci.aci_netflow_monitor_policy: | |
| cisco.aci.aci_netflow_monitor_to_exporter: |
…_netflow_monitor_to_exporter.
gmicol
dismissed stale reviews from akinross, samiib, shrsr, and anvitha-jain
via
87194aa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new modules:
is part of issue #126