[minor change] Added modules and tests for missing 1-N children for BD. #600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added modules and tests for 1-N Relationships for BD. - bd_to_netflow_monitor_policy - bd_rogue_exception_mac 2. Fixed missing clean-up in bd_to_l3out tests.
samiib
force-pushed
the
534_bd_child_modules
branch
from
94bf795 to
460e912
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
===========================================
- Coverage 96.30% 35.61% -60.69%
===========================================
Files 241 243 +2
Lines 11024 11084 +60
Branches 1658 1664 +6
===========================================
- Hits 10617 3948 -6669
- Misses 308 7136 +6828
+ Partials 99 0 -99
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
samiib
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
shrsr
akinross
requested changes
Feb 13, 2024
tests/integration/targets/aci_bd_rogue_exception_mac/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/aci_bd_rogue_exception_mac/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/aci_bd_to_netflow_monitor_policy/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/aci_bd_rogue_exception_mac/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/aci_bd_to_netflow_monitor_policy/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/aci_bd_to_netflow_monitor_policy/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/aci_bd_to_netflow_monitor_policy/tasks/main.yml
Outdated
Show resolved
Hide resolved
samiib
force-pushed
the
534_bd_child_modules
branch
from
c0401d8 to
a339ba2
Compare
akinross
requested changes
Feb 21, 2024
samiib
force-pushed
the
534_bd_child_modules
branch
from
a339ba2 to
7dc4f24
Compare
gmicol
requested changes
Feb 26, 2024
samiib
force-pushed
the
534_bd_child_modules
branch
from
674a190 to
a7c0d97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #534