Skip to content

Introduced GitHub Actions initial workflow#28

Merged
paduffy merged 1 commit intoCiscoDevNet:mainfrom
silabs-ThibautC:initial-gh-action-workflow
Feb 27, 2025
Merged

Introduced GitHub Actions initial workflow#28
paduffy merged 1 commit intoCiscoDevNet:mainfrom
silabs-ThibautC:initial-gh-action-workflow

Conversation

@silabs-ThibautC
Copy link
Copy Markdown
Collaborator

It runs on the latest ubuntu, install gcc and runs ./build.sh It was generated using GitHub Copilot

It runs on the latest ubuntu, installl gcc and runs ./build.sh
It was generated using GitHub Copilot
@silabs-ThibautC silabs-ThibautC force-pushed the initial-gh-action-workflow branch from 63286c9 to 582998e Compare December 16, 2024 15:09
@paduffy
Copy link
Copy Markdown
Collaborator

paduffy commented Dec 16, 2024

To be sure I am understanding the Action. Whenever a push or pull is attempted, the linux build is executed. If the build fails, does the invoking push or pull fail? Thanks

@silabs-ThibautC
Copy link
Copy Markdown
Collaborator Author

silabs-ThibautC commented Dec 17, 2024

Whenever a push is attempted, github will trigger a job that will check the Linux build still works. It will not block the push. It could auto-reject a PR.

https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows

I'd recommend to enable Require status checks to pass before merging on main.
See https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule

@silabs-ThibautC
Copy link
Copy Markdown
Collaborator Author

Is there any plan to move forward with that PR anytime soon? :-)

@manojnacsl manojnacsl self-requested a review February 27, 2025 16:44
@paduffy paduffy merged commit 9ef5400 into CiscoDevNet:main Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants