Skip to content

Migration ap (DCNE-315) #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhercot merged 7 commits into from
Mar 29, 2025
Merged

Migration ap (DCNE-315) #1320

lhercot merged 7 commits into from
Mar 29, 2025

Conversation

@akinross
Copy link
Collaborator

@akinross akinross commented Mar 17, 2025

No description provided.

shrsr
shrsr requested changes Mar 20, 2025
View reviewed changes
@akinross akinross requested a review from shrsr March 20, 2025 15:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.04082% with 264 lines in your changes missing coverage. Please review.

Project coverage is 86.72%. Comparing base (b00b58c) to head (42d6eae).

Files with missing lines Patch % Lines
...ernal/provider/resource_aci_application_profile.go 79.03% 198 Missing and 27 partials ⚠️
internal/provider/resource_aci_bridge_domain.go 82.67% 22 Missing ⚠️
...al/provider/data_source_aci_application_profile.go 94.27% 9 Missing and 2 partials ⚠️
internal/provider/resource_aci_application_epg.go 80.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1320      +/-   ##
==========================================
- Coverage   86.81%   86.72%   -0.10%     
==========================================
  Files         129      131       +2     
  Lines       74394    75661    +1267     
==========================================
+ Hits        64588    65619    +1031     
- Misses       7800     8007     +207     
- Partials     2006     2035      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shrsr
shrsr previously approved these changes Mar 20, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akinross akinross requested a review from shrsr March 20, 2025 19:40
shrsr
shrsr requested changes Mar 25, 2025
View reviewed changes
gen/definitions/properties.yaml Outdated

fvRsAEPgMonPol:
overwrites:
relation_to_application_epg_monitoring_policy: "relation_to_monitor_policy"
Copy link
Collaborator

@shrsr shrsr Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be "relation_to_monitoring_policy"?

@akinross akinross requested a review from shrsr March 25, 2025 17:14
shrsr
shrsr previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gmicol
gmicol approved these changes Mar 28, 2025
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Mar 29, 2025
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit c5ac90b into CiscoDevNet:master Mar 29, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhercot lhercot lhercot approved these changes

@shrsr shrsr shrsr approved these changes

@anvitha-jain anvitha-jain anvitha-jain approved these changes

@sajagana sajagana sajagana approved these changes

@gmicol gmicol gmicol approved these changes

@samiib samiib Awaiting requested review from samiib samiib is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@akinross @codecov-commenter @lhercot @shrsr @anvitha-jain @sajagana @gmicol