Migration docs (DCNE-321) #1322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
akinross
force-pushed
the
migration_docs
branch
2 times, most recently
from
a1b51a5 to
3fa9305
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1322 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 129 129
Lines 74394 74394
=======================================
Hits 64588 64588
Misses 7800 7800
Partials 2006 2006 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shrsr
requested changes
Mar 21, 2025
shrsr
requested changes
Mar 25, 2025
akinross
force-pushed
the
migration_docs
branch
from
5011b25 to
b0f42bd
Compare
sajagana
requested changes
Mar 27, 2025
shrsr
previously approved these changes
Mar 27, 2025
Collaborator
shrsr
left a comment
shrsr
left a comment
There was a problem hiding this comment.
Apart from the use of "new style attributes".. everything LGTM!
gmicol
requested changes
Mar 28, 2025
shrsr
previously approved these changes
Mar 28, 2025
Collaborator
shrsr
left a comment
shrsr
left a comment
There was a problem hiding this comment.
Apart from the use of "new style attributes".. everything LGTM
gmicol
previously approved these changes
Mar 29, 2025
Collaborator
gmicol
left a comment
gmicol
left a comment
There was a problem hiding this comment.
Maybe we have to revisit the "old/new style attributes" formulation but otherwise LGTM
akinross
force-pushed
the
migration_docs
branch
from
03aaac8 to
666784d
Compare
akinross
dismissed stale reviews from anvitha-jain, sajagana, samiib, and gmicol
via
c684c36
akinross
force-pushed
the
migration_docs
branch
from
c684c36 to
8413e06
Compare
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
lhercot
requested changes
Apr 17, 2025
akinross
force-pushed
the
migration_docs
branch
from
5a84273 to
ba5a0ec
Compare
lhercot
requested changes
Apr 18, 2025
akinross
force-pushed
the
migration_docs
branch
from
b333b9b to
352083d
Compare
akinross
force-pushed
the
migration_docs
branch
from
352083d to
d420ee7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.