Skip to content

Readme/running tests#201

Merged
bfolie merged 5 commits intodevelopfrom
readme/running-tests
Feb 7, 2020
Merged

Readme/running tests#201
bfolie merged 5 commits intodevelopfrom
readme/running-tests

Conversation

@bfolie
Copy link
Copy Markdown

@bfolie bfolie commented Feb 6, 2020

Citrine Python PR

Description

Inspired by some recent onboarding experiences, this fleshes out the Readme and Contributing files to be more explicit. It also adds some missing dependencies to the Pipfile

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.

Copy link
Copy Markdown
Contributor

@dekatzenel dekatzenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! I wish I had this when I was getting started

@bfolie bfolie merged commit d190b67 into develop Feb 7, 2020
@bfolie bfolie deleted the readme/running-tests branch October 2, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants