Merged
Conversation
added 4 commits
February 7, 2020 08:39
(outer product implies the elements should have units temp*time -- but this is more like a set of coordinates, which is a cartesian product)
bfolie
reviewed
Feb 7, 2020
bfolie
reviewed
Feb 7, 2020
Co-Authored-By: bfolie <bfolie@citrine.io>
bfolie
reviewed
Feb 7, 2020
gregor-robinson
suggested changes
Feb 10, 2020
Co-Authored-By: bfolie <bfolie@citrine.io>
Co-Authored-By: gregor-robinson <53885379+gregor-robinson@users.noreply.github.com>
Co-Authored-By: gregor-robinson <53885379+gregor-robinson@users.noreply.github.com>
Co-Authored-By: gregor-robinson <53885379+gregor-robinson@users.noreply.github.com>
Co-Authored-By: gregor-robinson <53885379+gregor-robinson@users.noreply.github.com>
Co-Authored-By: gregor-robinson <53885379+gregor-robinson@users.noreply.github.com>
Author
|
I think all suggestions have been added in now -- lmk if I missed anything! |
Contributor
|
cc: @eddotman changed base branch to master as part of the master flow update. |
| An acceptable NDME depends on how the model is used. | ||
| Generally, NDME > 0.9 indicates a model with very high error. | ||
| If 0.9 > NDME > 0.6, this model is typically a good candidate for a design workflow. | ||
| Lower values of NDME indicate increasingly accurate models. |
Contributor
There was a problem hiding this comment.
Here would be a nice place to explain what a lower value means as a candidate for a design workflow, continuing the thought from the previous sentence.
Author
There was a problem hiding this comment.
Changed! lmk what you think in the new update
added 2 commits
March 5, 2020 11:04
gregor-robinson
approved these changes
Mar 5, 2020
maxhutch
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Description
Some quick suggested changes to the documentation:
MeanColumnshould be aStdColumn-- unless I misunderstood the example.Product design space, since I think this is the correct mathematical concept that describes what is happening.errorand not necessarily highuncertainty.PR Type:
Adherence to team decisions
^^^N/A to these -- only changed documentation text.