Skip to content

Fix key reference in AraDefinitionCollection.get_with_version()#224

Merged
dekatzenel merged 3 commits intodevelopfrom
bugfix/PLA-2567-get_with_version
Feb 19, 2020
Merged

Fix key reference in AraDefinitionCollection.get_with_version()#224
dekatzenel merged 3 commits intodevelopfrom
bugfix/PLA-2567-get_with_version

Conversation

@dekatzenel
Copy link
Copy Markdown
Contributor

Citrine Python PR

Description

Please briefly explain the goal of the changes/this PR.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.

@dekatzenel dekatzenel requested a review from maxhutch February 19, 2020 18:33
@dekatzenel dekatzenel merged commit c8cc3ae into develop Feb 19, 2020
@dekatzenel dekatzenel deleted the bugfix/PLA-2567-get_with_version branch February 19, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants