Change scores MLI and MEI to LI and EI#233
Merged
Conversation
maxhutch
approved these changes
Feb 25, 2020
| return { | ||
| 'MLI': MLIScore, | ||
| 'MEI': MEIScore | ||
| 'MLI': LIScore, |
Contributor
There was a problem hiding this comment.
Note that this makes the change non-breaking wrt the API.
Author
There was a problem hiding this comment.
I've added a comment to that affect in the PR description, because I think that's the most important thing for @andyczerwonka . This user-facing change does not compel the backend code or the API to change.
Contributor
|
Looks VERY good to me XD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Description
The Scores "MLI" and "MEI" are actually scoring the likelihood of improvement and expected improvement. The addition of "Maximum" is a misnomer.
Note this change is non-breaking with respect to the API and doesn't require modifying backend code. The backend code can continue to refer to these objects as "MLI" and "MEI."
PR Type:
Adherence to team decisions