Adding Ara columns for Composition values#234
Merged
Conversation
These reflect the four column definitions added on the backend.
bfolie
reviewed
Feb 26, 2020
Comment on lines
+271
to
+272
| n: int | ||
| index of the component name to extract, starting with 1 for the biggest |
There was a problem hiding this comment.
What happens if n is larger than the number of components? For NthBiggestComponentQuantityColumn I would expect to get a value of 0, but I do not know what to expect here.
Contributor
Author
There was a problem hiding this comment.
Its empty. I'll clarify in docs.
bfolie
reviewed
Feb 26, 2020
|
|
||
| def __init__(self, *, | ||
| data_source: str, | ||
| n: int): |
There was a problem hiding this comment.
Should we set n=1 as the default? I think it depends on how we expect people to use this column (will they almost always be grabbing the largest amount?)
Contributor
Author
There was a problem hiding this comment.
Given that "N" is in the name, I'd say "no".
bfolie
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Description
This PR adds four column definitions for composition-valued variables in Ara definitions.
PR Type:
Adherence to team decisions