Skip to content

Pla 3297/warning on empty names#244

Merged
maxhutch merged 4 commits intomasterfrom
PLA-3297/warning-on-empty-names
Mar 6, 2020
Merged

Pla 3297/warning on empty names#244
maxhutch merged 4 commits intomasterfrom
PLA-3297/warning-on-empty-names

Conversation

@bfolie
Copy link
Copy Markdown

@bfolie bfolie commented Mar 5, 2020

Citrine Python PR

Description

Throw an exception if the user calls add_all_ingredients using a process template that does not have allowed_names defined.

With masterflow do we need to do a version bump for each PR?

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.

@bfolie bfolie requested review from maxhutch and sdedkins March 5, 2020 21:26
Copy link
Copy Markdown
Contributor

@maxhutch maxhutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfolie
Copy link
Copy Markdown
Author

bfolie commented Mar 5, 2020

With the change to masterflow, only authorized users can merge PRs and I am not an authorized user.

@maxhutch maxhutch merged commit c8b937e into master Mar 6, 2020
@maxhutch maxhutch deleted the PLA-3297/warning-on-empty-names branch March 6, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants