Skip to content

Add dry_run param to data_concepts register & delete#263

Merged
dekatzenel merged 1 commit intomasterfrom
feature/PLA-2186-dry-run
Mar 17, 2020
Merged

Add dry_run param to data_concepts register & delete#263
dekatzenel merged 1 commit intomasterfrom
feature/PLA-2186-dry-run

Conversation

@dekatzenel
Copy link
Copy Markdown
Contributor

Citrine Python PR

Description

Add dry_run param to data_concepts register & delete

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.

@dekatzenel dekatzenel requested review from anduill and maxhutch March 17, 2020 17:56
@dekatzenel
Copy link
Copy Markdown
Contributor Author

Copy link
Copy Markdown
Contributor

@maxhutch maxhutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxhutch
Copy link
Copy Markdown
Contributor

Note that we also want to add documentation to the user guide somewhere around here

@dekatzenel dekatzenel merged commit de98c34 into master Mar 17, 2020
@dekatzenel dekatzenel deleted the feature/PLA-2186-dry-run branch March 17, 2020 18:15
maxhutch added a commit that referenced this pull request Mar 18, 2020
#263
added the "dry_run" option, which is a new feature, so minor bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants