Add method for validate-templates endpoint#271
Conversation
anduill
left a comment
There was a problem hiding this comment.
this seems like a simple PR. I don't see anything glaring. This just hits the endpoint for validation right? I don't think I saw anything else.
There's also a couple of small tweaks to how testing works more broadly in session.py |
anduill
left a comment
There was a problem hiding this comment.
please mark this as alpha. Afterwards, I, David Garcia, will approve this Pull Request.
Upon reflection, this is beta because the core backend business logic is already established and well-tested |
I don't think the [Beta] tag is being used in citrine-python (since it's 0.x.x, isn't everything beta?). But I agree it's not alpha, since unlike Ara we don't expect it to be volatile. |
anduill
left a comment
There was a problem hiding this comment.
Ok, I approve this with the understanding that this new client feature can be expected to always work. (i.e. it's marked as BETA). Any backend services that this feature depends on are also BETA or better. If there is ANY doubt on these invariants, it might be better to mark this as ALPHA instead.
Citrine Python PR
Description
Add method to hit backend endpoint /validate-templates
PR Type:
Adherence to team decisions