Add validation that the version has been increased compared to master#275
Merged
dekatzenel merged 1 commit intomasterfrom Apr 3, 2020
Merged
Add validation that the version has been increased compared to master#275dekatzenel merged 1 commit intomasterfrom
dekatzenel merged 1 commit intomasterfrom
Conversation
Contributor
Author
|
Success - the correct failure this time! |
6 tasks
Add bumping version to PR template Bump version (also reflecting prior changes)
dekatzenel
force-pushed
the
feature/mandatory-version-bumps
branch
from
99bcdaa to
ec15e32
Compare
Contributor
Author
|
@maxhutch @mcgalcode In addition to general correctness, I would appreciate a sanity check/improvement recommendations on my bash script. If you do a review, please let me know if this is something you feel confident in doing |
maxhutch
suggested changes
Apr 3, 2020
Contributor
maxhutch
left a comment
maxhutch
left a comment
There was a problem hiding this comment.
This looks good. One nit on the version bump. I did review but am not super confident in the bash logic.
|
|
||
| setup(name='citrine', | ||
| version='0.9.1', | ||
| version='0.10.0', |
Contributor
Author
There was a problem hiding this comment.
I'm including all the things I forgot, i.e. the commits I forgot to do bumps for are minor version bumps
teekennedy
reviewed
Apr 3, 2020
| exit 4 | ||
| fi | ||
| fi | ||
| fi |
Contributor
There was a problem hiding this comment.
I gave this bash script a cursory glance and everything here is good shell scripting:
set -eu👍 I normally add in-o pipefailbut there's no piping here so it's N/A- quoted arguments to test builtin
- straightforward control flow
maxhutch
approved these changes
Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Description
Add automated validation that the version in setup.py has been bumped
PR Type:
Adherence to team decisions