Merged
Conversation
asantas93
changed the title
maxhutch
reviewed
Apr 3, 2020
Contributor
maxhutch
left a comment
maxhutch
left a comment
There was a problem hiding this comment.
This looks sensible. One naming request
| raise TypeError( | ||
| "{} must be a dictionary or None but was {}".format(field, value)) | ||
| deserialized = clazz.build(value) | ||
| elif issubclass(clazz, Property): |
Contributor
There was a problem hiding this comment.
To avoid the namespace collision with the property attribute, could we use this as properties.Property (as we have in some other places?)
Contributor
Author
There was a problem hiding this comment.
That is actually a python syntax error, surprisingly. I could give it an alias though.
Contributor
There was a problem hiding this comment.
anything to disambiguate it
…' into feature/dataset-on-data-concepts
maxhutch
approved these changes
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Citrine Python PR
Description
Readies client for new
datasetfield which will appear on all data concepts classes, if they were created from the backend's response.PR Type:
Adherence to team decisions