Skip to content

Use non-paging implementation of list in seeding utils#279

Merged
dekatzenel merged 2 commits intomasterfrom
bugfix/no-paging-in-list
Apr 6, 2020
Merged

Use non-paging implementation of list in seeding utils#279
dekatzenel merged 2 commits intomasterfrom
bugfix/no-paging-in-list

Conversation

@dekatzenel
Copy link
Copy Markdown
Contributor

Citrine Python PR

Description

Use non-paging implementation of list in find_or_create.find_collection()

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in setup.py

@dekatzenel dekatzenel marked this pull request as ready for review April 6, 2020 15:34
ventura-rivera
ventura-rivera previously approved these changes Apr 6, 2020
Copy link
Copy Markdown
Contributor

@ventura-rivera ventura-rivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dekatzenel dekatzenel merged commit f0ac12d into master Apr 6, 2020
@dekatzenel dekatzenel deleted the bugfix/no-paging-in-list branch April 6, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants