Skip to content

Alias filename to name#311

Merged
bfolie merged 1 commit intomasterfrom
feature/filename-alias
Apr 23, 2020
Merged

Alias filename to name#311
bfolie merged 1 commit intomasterfrom
feature/filename-alias

Conversation

@bfolie
Copy link
Copy Markdown

@bfolie bfolie commented Apr 23, 2020

Citrine Python PR

Description

Gives FileLink objects a .name field which is an alias to .filename.

Methods like this https://github.com/CitrineInformatics/citrine-python/blob/feature/filename-alias/src/citrine/seeding/find_or_create.py#L4 assume that all resources with uids also have a .name field. That's mostly true but not true for FileLinks.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in setup.py

@bfolie bfolie requested a review from dekatzenel April 23, 2020 20:44
@bfolie bfolie merged commit 9231fc9 into master Apr 23, 2020
@bfolie bfolie deleted the feature/filename-alias branch October 2, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants